Closed iainmcgin closed 7 years ago
Merging #122 into master will increase coverage by
0.46%
. The diff coverage is97.53%
.
@@ Coverage Diff @@
## master #122 +/- ##
============================================
+ Coverage 70.65% 71.11% +0.46%
- Complexity 469 480 +11
============================================
Files 65 65
Lines 2675 2690 +15
Branches 255 246 -9
============================================
+ Hits 1890 1913 +23
+ Misses 705 701 -4
+ Partials 80 76 -4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7b7ef9f...8ba1963. Read the comment docs.
Proposed changes made.
To unblock David in cutting a 0.2.1 release, I'll go ahead and merge this. @StanKocken we're past the two day review period, if you have any comments please do still submit them and I'll fix in follow-up.
The previous changes made were introducing too much duplicate code, increasing the likelihood of inconsistent future modifications and bugs. This change refactors the implementations into the utils class, and uses parameterized unit tests to check that all implementations are consistent, without affecting the convenience of the API.
This finishes the implementation of #99.