openid / OpenYOLO-Android

Android protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
115 stars 18 forks source link

SmartLock manual migration guide #123

Closed iainmcgin closed 7 years ago

iainmcgin commented 7 years ago

This is the first complete pass of documenting how to migrate from the Smart Lock for Passwords API to the OpenYOLO API.

iainmcgin commented 7 years ago

@tikurahul FYI.

codecov-io commented 7 years ago

Codecov Report

Merging #123 into master will increase coverage by 1.2%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #123     +/-   ##
===========================================
+ Coverage     70.65%   71.85%   +1.2%     
- Complexity      469      482     +13     
===========================================
  Files            65       65             
  Lines          2675     2690     +15     
  Branches        255      246      -9     
===========================================
+ Hits           1890     1933     +43     
+ Misses          705      682     -23     
+ Partials         80       75      -5
Impacted Files Coverage Δ Complexity Δ
protocol/java/org/openyolo/protocol/Hint.java 92.37% <0%> (+0.4%) 21% <0%> (+2%) :arrow_up:
...ava/org/openyolo/protocol/HintRetrieveRequest.java 92.38% <0%> (+0.46%) 14% <0%> (+2%) :arrow_up:
...g/openyolo/protocol/CredentialRetrieveRequest.java 78.89% <0%> (+0.63%) 14% <0%> (-1%) :arrow_down:
...va/org/openyolo/protocol/CredentialSaveResult.java 91.93% <0%> (+0.86%) 10% <0%> (+2%) :arrow_up:
...java/org/openyolo/protocol/HintRetrieveResult.java 90% <0%> (+0.93%) 11% <0%> (+2%) :arrow_up:
...rotocol/java/org/openyolo/protocol/Credential.java 92.3% <0%> (+1.39%) 20% <0%> (-1%) :arrow_down:
...a/org/openyolo/protocol/CredentialSaveRequest.java 86.88% <0%> (+1.43%) 11% <0%> (+2%) :arrow_up:
...rg/openyolo/protocol/CredentialRetrieveResult.java 91.66% <0%> (+1.92%) 12% <0%> (-1%) :arrow_down:
.../org/openyolo/protocol/CredentialDeleteResult.java 98.43% <0%> (+2.72%) 11% <0%> (-1%) :arrow_down:
...lo/protocol/internal/AdditionalPropertiesUtil.java 82.85% <0%> (+2.85%) 9% <0%> (+6%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b7ef9f...2f47c9b. Read the comment docs.

iainmcgin commented 7 years ago

Thanks for the detailed review comments everyone, PTAL.

iainmcgin commented 7 years ago

Yeah, we can figure out our index and cross-referencing once we've got all the docs we want.