openid / OpenYOLO-Android

Android protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
115 stars 18 forks source link

Proguard exclusion is too broad #147

Closed riyaz closed 1 year ago

riyaz commented 6 years ago

src - https://github.com/openid/OpenYOLO-Android/blob/master/api/proguard-rules.txt

isn't this too broad?

-keep class org.hamcrest.** { *; }

iainmcgin commented 6 years ago

It is, but we also only depend on hamcrest-core rather than the full library, so the impact is fairly small. If you have a suggestion for a narrower keep rule we'd be happy to accept a PR.

timcappalli commented 1 year ago

This repo is being archived. Closing issue.