search

openid / OpenYOLO-Android

Android protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
115 stars 18 forks source link

Tapping the back button on the ProviderPickerActivity will now return a user canceled result. #77

Closed dxslly closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.1%. The diff coverage is 75.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #77     +/-   ##
===========================================
+ Coverage     71.25%   71.36%   +0.1%     
- Complexity      446      454      +8     
===========================================
  Files            61       62      +1     
  Lines          2505     2546     +41     
  Branches        242      243      +1     
===========================================
+ Hits           1785     1817     +32     
- Misses          653      662      +9     
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
.../org/openyolo/protocol/CredentialDeleteResult.java 100% <ø> (ø) 9 <0> (ø) :arrow_down:
...va/org/openyolo/protocol/CredentialSaveResult.java 92.45% <100%> (+0.29%) 8 <0> (ø) :arrow_down:
...va/org/openyolo/api/ui/ProviderPickerActivity.java 19.8% <62.5%> (+11.16%) 4 <3> (+1) :arrow_up:
...java/org/openyolo/api/internal/ActivityResult.java 89.47% <89.47%> (ø) 7 <7> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c3e2c5...a7f287d. Read the comment docs.

dxslly commented 7 years ago

Opened https://github.com/openid/OpenYOLO-Android/issues/80 to dismiss the picker when the user taps outside it's bounds.

iainmcgin commented 7 years ago

There are some conflicts you'll need to resolve before we can merge.