openid / OpenYOLO-Web

Web protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
100 stars 16 forks source link

Updated code to correctly minify the library with JSCompiler. #15

Closed TMSCH closed 7 years ago

TMSCH commented 7 years ago

This required adding externs that include type definitions for interfaces that are exchanged between the client and the provider. Updated the travis script to make sure it compiles correctly.

codecov-io commented 7 years ago

Codecov Report

Merging #15 into master will decrease coverage by 0.01%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   78.86%   78.84%   -0.02%     
==========================================
  Files          34       34              
  Lines        1216     1234      +18     
  Branches      130      131       +1     
==========================================
+ Hits          959      973      +14     
- Misses        220      224       +4     
  Partials       37       37
Impacted Files Coverage Δ
ts/protocol/comms.ts 88% <ø> (ø) :arrow_up:
ts/protocol/data.ts 100% <ø> (ø) :arrow_up:
ts/protocol/preload_request.ts 100% <ø> (ø) :arrow_up:
ts/api/api.ts 27.73% <ø> (+5.68%) :arrow_up:
ts/spi/spi.ts 91.66% <ø> (+5.95%) :arrow_up:
ts/protocol/enums.ts 80% <ø> (-20%) :arrow_down:
ts/protocol/post_messages.ts 100% <100%> (ø) :arrow_up:
ts/protocol/rpc_messages.ts 94.54% <100%> (ø) :arrow_up:
ts/protocol/secure_channel.ts 88.54% <100%> (ø) :arrow_up:
ts/protocol/errors.ts 73.33% <66.66%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5df1d3...44d7106. Read the comment docs.

TMSCH commented 7 years ago

Thanks Rahul and Iain!