openid / OpenYOLO-Web

Web protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
100 stars 16 forks source link

Add no-op variant of the API for unsupported browsers #19

Closed iainmcgin closed 6 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will decrease coverage by 9.36%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   86.73%   77.37%   -9.37%     
==========================================
  Files          32       34       +2     
  Lines        1251     1255       +4     
  Branches      155      136      -19     
==========================================
- Hits         1085      971     -114     
- Misses        166      242      +76     
- Partials        0       42      +42
Impacted Files Coverage Δ
ts/protocol/errors.ts 70.96% <ø> (-2.51%) :arrow_down:
ts/api/api.ts 23.02% <ø> (-53.9%) :arrow_down:
ts/api/provider_frame_elem.ts 23.07% <0%> (-41.93%) :arrow_down:
ts/test_utils/timeout.ts 76.92% <0%> (-23.08%) :arrow_down:
ts/spi/spi.ts 91.66% <0%> (-8.34%) :arrow_down:
ts/protocol/utils.ts 71.59% <0%> (-7.96%) :arrow_down:
ts/api/hint_available_request.ts 93.75% <0%> (-6.25%) :arrow_down:
ts/test_utils/listeners.ts 88.23% <0%> (-6.21%) :arrow_down:
ts/spi/provider_frame.ts 78.1% <0%> (-5.53%) :arrow_down:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1f6ae8...37d1499. Read the comment docs.

iainmcgin commented 7 years ago

PTAL

iainmcgin commented 7 years ago

Testing it in-situ is difficult as it performs the replacement as a one-time operation on load of the module. I can refactor to at least pull out and test the logic that makes the decision.

TMSCH commented 6 years ago

Closing in favor of #61