search

openid / OpenYOLO-Web

Web protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
100 stars 16 forks source link

Add the ability to cancel requests #27

Closed tikurahul closed 7 years ago

tikurahul commented 7 years ago

Sorry about all the formatting noise.

codecov-io commented 7 years ago

Codecov Report

Merging #27 into master will decrease coverage by 0.07%. The diff coverage is 87.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage    87.2%   87.12%   -0.08%     
==========================================
  Files          32       32              
  Lines        1258     1282      +24     
  Branches      159      161       +2     
==========================================
+ Hits         1097     1117      +20     
- Misses        161      165       +4
Impacted Files Coverage Δ
ts/api/base_request.ts 98.63% <100%> (+0.1%) :arrow_up:
ts/protocol/errors.ts 74.5% <100%> (+1.04%) :arrow_up:
ts/protocol/utils.ts 80.43% <71.42%> (+0.88%) :arrow_up:
ts/api/api.ts 76.11% <84.31%> (-1.27%) :arrow_down:
ts/api/navigator_credentials.ts 88.4% <90%> (-1.31%) :arrow_down:
ts/api/provider_frame_elem.ts 70% <0%> (+5%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ecc1aa...84ef42e. Read the comment docs.

tikurahul commented 7 years ago

You are right. We will need to notify the provider frame, that the operation is being cancelled, so it can use the interaction provider to cancel any pending UI elements being rendered. I am going to work on a version of the PR on the provider side.