Closed TMSCH closed 7 years ago
Merging #43 into master will increase coverage by
4.24%
. The diff coverage is94.4%
.
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 87.26% 91.51% +4.24%
==========================================
Files 34 34
Lines 1429 1449 +20
Branches 168 176 +8
==========================================
+ Hits 1247 1326 +79
+ Misses 182 123 -59
Impacted Files | Coverage Δ | |
---|---|---|
ts/protocol/rpc_messages.ts | 100% <ø> (+4.61%) |
:arrow_up: |
ts/api/provider_frame_elem.ts | 61.9% <ø> (ø) |
:arrow_up: |
ts/protocol/errors.ts | 93.02% <100%> (+3.99%) |
:arrow_up: |
ts/api/hint_request.ts | 100% <100%> (ø) |
:arrow_up: |
ts/api/api.ts | 92.65% <100%> (+22.97%) |
:arrow_up: |
ts/api/credential_request.ts | 100% <100%> (ø) |
:arrow_up: |
ts/spi/spi.ts | 100% <100%> (ø) |
:arrow_up: |
ts/api/exports.ts | 100% <100%> (ø) |
|
ts/spi/provider_frame.ts | 87.4% <87.5%> (+1.47%) |
:arrow_up: |
ts/api/navigator_credentials.ts | 92.63% <88.46%> (+2.49%) |
:arrow_up: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc84170...ad37450. Read the comment docs.
Tests coverage is >90%! :D
Thanks Rahul!
Thanks Iain!
List of changes:
wrapBrowserRequest
logic from the initialization. Instead using a per request logic that can be triggered with abrowserWrappingRequired
error.Error
class as the prototype is not extendable and it can lead to unexpected behavior in compiled code.navigator.credentials
wrapper for browser without it.navigator_credentials.ts
file to useawait
construct instead ofPromise
syntax.OpenYoloInternalError
onopenyolo_spi
namespace so that providers' implementations' can return specific errors (noCredentialsAvailable
,userCanceled
,browserWrappingRequired
)Please review very carefully. I tested the code with Smart Lock implementation with success.