search

openid / OpenYOLO-Web

Web protocol for credential exchange and update - "You Only Login Once"
http://openid.net/wg/ac/
Apache License 2.0
100 stars 16 forks source link

Disable navigator.credentials fallback when not on https. #44

Closed TMSCH closed 7 years ago

TMSCH commented 7 years ago

This avoid "requestFailed" error when navigator.credentials operations are called on http (i.e. E2E tests).

Also fixed hintsAvailable not triggering the fallback.

TMSCH commented 7 years ago

Thanks Rahul!

codecov-io commented 7 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.16%. The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   91.51%   91.34%   -0.17%     
==========================================
  Files          34       34              
  Lines        1449     1456       +7     
  Branches      176      178       +2     
==========================================
+ Hits         1326     1330       +4     
- Misses        123      126       +3
Impacted Files Coverage Δ
ts/api/api.ts 92.65% <100%> (ø) :arrow_up:
ts/protocol/utils.ts 82.81% <100%> (+0.27%) :arrow_up:
ts/api/navigator_credentials.ts 92.7% <100%> (+0.07%) :arrow_up:
ts/spi/provider_frame.ts 86.46% <87.87%> (-0.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52c5329...d4351df. Read the comment docs.