openid / federation

4 stars 3 forks source link

Rename title of section 8.3 to "Resolve Entity" #40

Closed Razumain closed 2 days ago

Razumain commented 1 month ago

This is just a nit, but I'm throwing it in here for it to be noted and potentially fixed

The heading of 8.3 is currently "Resolve Entity Statement", but that is incorrect. As described by the leading text, you are not resolving an Entity Statement, but processed metadata and validated Trust Marks for the specified Entity.

rohe commented 1 month ago

You're right and it should be fixed.

jcmelati commented 1 month ago

If I understand the intention of the text, the resolved metadata and (validated) Trust Marks for an Entity are the result of the resolution of the subject's Entity Configuration Statement. The resolve endpoint exists solely to delegate the resolution of the trust chain to another party, as noted in section 8.3.3.

In this case, the title should indeed be corrected, but I believe that "Resolve Entity Configuration Statement" clarifies exactly what is being resolved and makes it clear that Subordinate Statements cannot be resolved via the resolve endpoint.

Razumain commented 1 month ago

The fact remains that the resolver is neither returning an Entity Configuration, nor an Entity Statement. The resolve response has its own structure and mime type. I believe a title must reflect what is returned to the requester, not what data that is internally examined in the resolver.

selfissued commented 3 weeks ago

I agree with @Razumain and will create a PR. @jcmelati, a Subordinate Statement is not an Entity, so I'm not worried about people confusing the two.