search

openid / oid4vc-haip-sd-jwt-vc

High Assurance Profile of OID4VP and OID4VCI using SD-JWT VC and mdocs that is privacy preserving, secure, and meets regulatory requirements
29 stars 7 forks source link

Order should be an array of claims.keys #81

Closed ntsbs closed 8 months ago

ntsbs commented 9 months ago

https://github.com/openid/oid4vc-haip-sd-jwt-vc/blob/75a17220959a28a208b04546d4337b9b5ed5c5bd/draft-oid4vc-haip-sd-jwt-vc.md?plain=1#L294

Currently, the spec mentions the order field in the credential issuer metadata and it says that it is

An array of claims.display.name values that lists them in the order they should be displayed by the Wallet.

This would mean:

[
    "Given Name",
    "Surname"
]

To reference the localized names makes no sense, especially since the display object is optional and it would be better to reference the keys of the claims object directly, therefore the order array should contain the attribute keys of the claims object in the order they should be displayed by the Wallet

This would mena:

[
    "given_name", 
    "last_name"
]
Sakurann commented 8 months ago

this is being fixed in https://github.com/openid/OpenID4VCI/pull/128/files#diff-1f424614b35a9899813079f1b1f6218631a2aedd993368ccb89bb81a9eda0289R2055