search

openid / openid4vp_ble

MIT License
7 stars 3 forks source link

crc checksum input #51

Open sschulz-t opened 4 months ago

sschulz-t commented 4 months ago

Regarding https://github.com/openid/openid4vp_ble/blob/e5370d5b7a2fa82b627b67bda6858ff81a64114d/main.md?plain=1#L344

In this case i assume the input is the chunk num and chunk data, however the specification should specify it clearly that no assumptions are needed.

gsasikumar commented 4 months ago

I thought the table was providing the clarity. But I agree we can make this change to provide better clarity. I will open a PR on the same by tomorrow.

sschulz-t commented 4 months ago

I think this should be written more precise. I was looking at this: https://github.com/openid/openid4vp_ble/blob/e5370d5b7a2fa82b627b67bda6858ff81a64114d/main.md?plain=1#L336-L344

The table says checksum of "data" and the text below the table specifies chunk payload as chunk data. One could easily misinterpret this and not include the seqNo in the crc.

I can work out a revised definition and create a PR if you want.

gsasikumar commented 3 months ago

@sschulz-t Yes it would be great if you can.