search

openid / sharedsignals

OpenID Shared Signals Working Group Repository
45 stars 11 forks source link

The examples for stream update requests should not include Transmitter-Supplied fields in the request #150

Closed ysarig1 closed 1 month ago

ysarig1 commented 3 months ago

The current examples for stream update requests (both PUT and PATCH) include fields that are Transmitter-Supplied ("iss" for PATCH, "iss" and "aud" for PUT) and they should be removed from the examples.

FragLegs commented 3 months ago

Transmitter-Supplied properties are perfectly acceptable in both PUT and PATCH. The only restriction is that if they do not match the Transmitter's expectation for those values, the Transmitter should return an error. In fact, the stream_id, which is Transmitter-Supplied, MUST be present in the request.

ysarig1 commented 3 months ago

Including those values in the examples is confusing, especially in the PATCH case. While they may be accepted in the request, there is no reason for them to be there in PATCH case.

FragLegs commented 1 month ago

This is being worked on in #152