search

openid / sharedsignals

OpenID Shared Signals Working Group Repository
45 stars 11 forks source link

Removing transmitter supplied fields from stream config PUT and PATCH… #152

Closed ysarig1 closed 1 month ago

ysarig1 commented 2 months ago

Removed the transmitter supplied fields from the stream config PUT and PATCH examples.

ysarig1 commented 2 months ago

@FragLegs, @appsdesh, @atultulshi Can you please review the PR and approve/comment?

ysarig1 commented 2 months ago

The existing language already clarifies -

Transmitter-Supplied properties beside the stream_id MAY be present, but they MUST match the expected value. Missing Transmitter-Supplied properties MUST be ignored by the Transmitter.

There may be reasons for the receiver to send the same values to make sure it's info matches the Tx info (and expect to receive error message, on mismatch)

I don't think this PR is needed. Please let me know your thoughts

The issue addressed by this PR is not if the fields can or can't be in the request but the fact that having a the fields in the examples is confusing. Having transmitter-supplied fields in an update request is an edge case and while it is allowed, it doesn't make sense to do so.