search

openid / sharedsignals

OpenID Shared Signals Working Group Repository
47 stars 12 forks source link

Remove stream configuration API to respond back with with HTTP 204 - No Content instead of HTTP 200 #67

Closed appsdesh closed 1 year ago

appsdesh commented 1 year ago

As explained in RFC9110 delete call to respond back with HTTP 204 if the action is successful and no further information is to be supplied.

Current SSF specification says the response should be HTTP 200 with the empty response body. The correct response code should be HTTP 204

Remove subject correctly calls out 204 as a response code

tulshi commented 1 year ago

Has this been fixed in the draft spec? The line here says "204 OK": https://github.com/openid/sharedsignals/blob/ae0cf793477bff3953001b1f4ef04da78b9325e1/openid-sharedsignals-framework-1_0.txt#L1655

appsdesh commented 1 year ago

Thanks for pointing this out.

Should we also clarify that "204" is "No Content" instead of an "OK"

FragLegs commented 1 year ago

Thanks for catching that @appsdesh . I have fixed it here in the world's tiniest pull request: #73