search

openigtlink / OpenIGTLink

Free, open-source network communication library for image-guided therapy
http://openigtlink.org
BSD 3-Clause "New" or "Revised" License
102 stars 184 forks source link

Override/Virtual issues #236

Closed tpaetz closed 3 years ago

tpaetz commented 3 years ago

GetNameOfClass and CreateAnother have to override the virtual methods of the base class. This is required to build OpenIGTLink in our environment with strict compiler warning/error handling.

leochan2009 commented 3 years ago

override is a C++11 feature, the build on Mac actually failed due to too many warnings: https://travis-ci.org/github/openigtlink/OpenIGTLink/builds/748557020 Need to modify the cmake file to activate the C++11.

leochan2009 commented 3 years ago

Another observation i have is that, you have only applied override for the tranform, image, point, string and status messages. The rest message is intact. As we are merging the pull request into the master branch, i would recommend have consistency for all message types