fixed various places with potential nullptr access

openigtlink / OpenIGTLink

Free, open-source network communication library for image-guided therapy

http://openigtlink.org

BSD 3-Clause "New" or "Revised" License

102 stars 184 forks source link

fixed various places with potential nullptr access #240

Closed tpaetz closed 3 years ago

leochan2009 commented 3 years ago

override is a C++11 feature, the build on Mac actually failed due to too many warnings: https://travis-ci.org/github/openigtlink/OpenIGTLink/jobs/761089146 Need to modify the cmake file to activate the C++11.

tpaetz commented 3 years ago

This pull request does not contain override/virtual adaptions but access to null pointers that result in crashes in our applications. I would appreciate if this can be handled independent of the #236 where override/virtual has been addressed.

leochan2009 commented 3 years ago

@tpaetz , exactly in #236, i have written some comments there as well.
@tokjun , for the master branch, are we still planning to support very old C++ compiler? could we just add this line: set (CMAKE_CXX_STANDARD 11) in the CMakefile ?

leochan2009 commented 3 years ago

Merge this pull request, #236 still need to be address immediately.