search

opening-hours / opening_hours.js

Library to parse and process the opening_hours tag from OpenStreetMap data
https://openingh.ypid.de/evaluation_tool/
224 stars 120 forks source link

Don't show PH warning if single-day rules are present #251

Open Nixill opened 6 years ago

Nixill commented 6 years ago

For example, Mo-Su 06:00-24:00; Nov Th[4] 06:00-17:30; Dec 24 06:00-17:00; Dec 25 off is the actual hours of the Kroger that I worked at once.

This set of hours has clearly taken public holidays into account and is stating that the store only closes early for Thanksgiving and Christmas Eve, and is completely unaffected by all other holidays. A PH tag would actually be detrimental to the parser, as the store has different hours on different holidays. Plus, the wording of the warning is ironic in this situation, as exactly specified days are more explicit than a "PH" tag.

ypid commented 6 years ago

Well, we could make the warning less aggressive by only showing it if the value does not contain rules with "closed" modifier (like off) but that would omit the warning for many valid cases.

But the warning includes the hint how to avoid it for your case:

If the amenity is open everyday including public holidays then you can make this explicit by writing "Mo-Su,PH".

Does this not work for you?

Just write it as:

Mo-Su,PH 06:00-24:00; Nov Th[4] 06:00-17:30; Dec 24 06:00-17:00; Dec 25 off

And job done and everybody is happy (including the validator 😄 ).