search

opening-hours / opening_hours.js

Library to parse and process the opening_hours tag from OpenStreetMap data
https://openingh.ypid.de/evaluation_tool/
223 stars 118 forks source link

PH for Jersey #397

Open Lee-Carre opened 3 years ago

Lee-Carre commented 3 years ago 
An error occurred during evaluation of the value "PH". Please submit a pull request: https://github.com/opening-hours/opening_hours.js. 
There are no holidays (PH) defined for country je.

Perma-link.

Public holidays for Jersey can be extracted from Bank Holiday Dates.

ypid commented 3 years ago

I updated my policy how to handle such issues https://github.com/opening-hours/opening_hours.js#holidays

Short, thank you but I cannot take the time to add the holidays myself. But you are welcome to work on it and I will take the time to integrate/merge your work.

Lee-Carre commented 2 years ago

Why closed when unresolved?

ypid commented 2 years ago

See https://github.com/opening-hours/opening_hours.js/issues/397#issuecomment-856956437 and #300.

Lee-Carre commented 2 years ago

OK, but what's the problem with leaving it open in order that it receive attention?

When I'm able to, then I will, myself. Unless someone takes it on first.

ypid commented 2 years ago

The issue is that open issues take at least some of my maintenance time when I look though open issues. But alright, as you are persistent, I will reopen it.

Lee-Carre commented 2 years ago

open issues take at least some of my maintenance time when I look though open issues.

I see. Understandable.

How about marking it in order to filter-out those of no interest in your default view of issues? Suggestions:

Same for #398 please.

Lee-Carre commented 2 years ago

For future reference, after I get around to nagging the local bureaucrats about publishing various data in useful formats (with permissive licensing), PH data would appear on opendata.gov.je (possibly with the holiday tag).