search

opening-hours / opening_hours.js

Library to parse and process the opening_hours tag from OpenStreetMap data
https://openingh.ypid.de/evaluation_tool/
222 stars 119 forks source link

Sa 7-13:30 #68

Open matkoniecz opened 9 years ago

matkoniecz commented 9 years ago

Prettifier is unable to recognise it as Sa 7:00-13:30.

"Sa 7-13" is recognised as "Sa 7:00-13:00" with comment

(Time range without minutes specified. Not very explicit! Please use this syntax instead e.g. "12:00-14:00".)

(EDIT: I encountered it in real OSM data, in edit https://www.openstreetmap.org/changeset/28047201 I fixed tag that had this problem).

ypid commented 9 years ago

I encountered this problem many times myself but I was unsure if I should fix it because I was not sure if this might be too much of input tolerance and also because the 7-13 and a opening_hours following the specs are handled by two different sub parsers. But I guess I will implement it …

dex2000 commented 8 years ago

Das Problem hier ist glaube ich eher die falsche Erkennung und weniger die anführende Null (die wohl bereits gefixt ist, oder ich übersehe was.).

Sa 7-13:30 wirft u.A. aus: "... verwende stattdessen 07:00-13:00" das ist eindeutig falsch oder irreführend oder beides.

ypid commented 8 years ago

Sa 7-13:30

Die Verwirrung rührt daher, dass das Beispiel der Bibliothek für die Syntax "07:00-13:00" sehr ähnlich zu dem von dir verwendetem Wert ist.

Die Funktion steht auf meiner todo.

The confusion is caused by the example of the library for the syntax "07:00-13:00" being very similar to your used value.

The feature is on my todo.

ypid commented 8 years ago

Problem is that currently HH:MM and HH cannot be combined in one time selector.