Code quality fix - Mutable fields should not be "public static".

openintents / notepad

OpenIntents Notepad

http://www.openintents.org/notepad/

47 stars 39 forks source link

Code quality fix - Mutable fields should not be "public static". #18

Closed faisal-hameed closed 8 years ago

faisal-hameed commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S2386 - Mutable fields should not be "public static". You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2386

Please let me know if you have any questions.

Faisal Hameed

friedger commented 8 years ago

These fields are final and not mutable

faisal-hameed commented 8 years ago

@friedger Internal state of the arrays can be modified even if we declare it final static. So the visibility of such fields should be reduces to the degree possible.