search

openintents / notepad

OpenIntents Notepad
http://www.openintents.org/notepad/
47 stars 39 forks source link

Added the Widget for OI Notepad #8

Closed shalinshah1993 closed 6 years ago

shalinshah1993 commented 11 years ago

Sticky Notes + Stack of Notes widgets added in the OI Notepad and also the superfluous code is removed as suggested in the previous Pull Requests. This code has all those changes with clean commit history and cleaned code.

aperomsik commented 11 years ago

The widespread whitespace changes in the xml files make it hard to review this pull request. Also, is a service really required?

shalinshah1993 commented 11 years ago

Yes the service is required since I have made the stack widget which requires a service in the background to fill its content and update it.

I am sorry for the whitespace changes but this issue is only in manifest xml could you please bear with me on this one or else I would have to send a fresh pull request.

aperomsik commented 11 years ago

Afraid I still don't understand, once you managed to remove the need for a service from one widget using the new EDITED intent, why the other one still needs a service. I suspect that you could do without it if you tried.

Note, if you would submit pull requests from a branch instead of from master, you would be able to update them by pushing to the same branch name without creating a new pull request.

shalinshah1993 commented 11 years ago

Yes the service is not required for that widget, however now I have made two different widgets for OI Notepad, one is sticky notes and other contains a stack of notes ie I have used a collection like this http://developer.android.com/images/appwidgets/StackWidget.png .

Could please elaborate this pull request topic.Y ou mean to say if I have a branch and if I have sent you a pull request from it then any change made in the branch after sending the pull request will be reflected in the puyll request?