openintents / safe

OI Safe
http://www.openintents.org/safe
44 stars 22 forks source link

Can't build latest stable release from source #12

Closed netmackan closed 10 years ago

netmackan commented 10 years ago

Hi, I am trying to build the latest stable release from source and are having some trouble. Is 1.4.1 on googlecode the latest release?

$ curl -O https://openintents.googlecode.com/files/Safe-source-1.4.1.zip
$ unzip Safe-source-1.4.1.zip
$ cd Safe-source-1.4.1/
$ ant -p
Buildfile: /tmp/a/Safe-source-1.4.1/build.xml
/tmp/a/Safe-source-1.4.1/build.xml:35: Cannot find /tmp/distribution/ant/build_common.xml imported from /tmp/a/Safe-source-1.4.1/build.xml

$ cd Safe
$ ant -p
Buildfile: /tmp/a/Safe-source-1.4.1/Safe/build.xml
/tmp/a/Safe-source-1.4.1/Safe/build.xml:35: Cannot find /tmp/a/distribution/ant/build_common.xml imported from /tmp/a/Safe-source-1.4.1/Safe/build.xml

It seems to be some build_common.xml missing?

rmceoin commented 10 years ago

You should use git to fetch the latest. Additionally it requires the OI Distribution. Try something more like this:

$ mkdir oisafe $ cd oisafe $ git clone https://github.com/openintents/safe.git $ git clone https://github.com/openintents/distribution.git $ cd distribution/DistributionLibrary/ $ cp template\ of\ local.properties local.properties $ vi local.properties $ ant debug $ cd ../../safe/Safe $ cp template\ of\ local.properties local.properties $ vi local.properties $ ant debug

netmackan commented 10 years ago

Thanks Randy, that worked like a charm.

However, some questions: 1) This is not 1.4.1 which seems to be the latest release (?) but 1.4.2-alpha from the master branch. Is this a stable version? 2) There are some bundled JAR files:

My goal is to be able to use OI Safe completely built from source and eventually have it included in a free software distribution/repository such as f-droid.org

Cheers, Markus

rmceoin commented 10 years ago

It's not the version from Play but I'd say it's stable. It's what I've been using because it fixes an annoying bug where you get asked for the master password twice in order to open the app. We just haven't pushed it out.

lib/android-support-v4.jar is the standard support library from the Android dev tools to allow for older versions of Android to use newer API's. I would imagine the source for it can be found somewhere.

lib/OISafeMyBackupPro.jar is proprietary. It's was made by the MyBackup dev to give it hooks into OI Safe to allow it to backup. https://play.google.com/store/apps/details?id=com.rerware.android.MyBackup I do not believe you can get the source for it. It might be as easy as removing the jar to remove that dependency. It's just that the app won't be able to be backed up by that tool without the jar. Nothing in the safe code refers to it.

netmackan commented 10 years ago

Ok I will have to look into paching it away then. First for security reasons as it is not easy to see what it does and secondly for it to be possible to include in f-droid. The application will then by listed with the antifeature UpstreamNonFree to indicate that some non-free parts had to be removed. https://f-droid.org/wiki/page/Antifeature:UpstreamNonFree

netmackan commented 10 years ago

OI Safe has now been added to f-droid: https://f-droid.org/repository/browse/?fdfilter=OI%20safe&fdid=org.openintents.safe

Big thanks for a great app!

Cheers, Markus