search

openiolink / io-link-master-shield-hat-sw

Software for the IO-Link Master Shield/Hat for Arduino and Raspberry Pi
Apache License 2.0
25 stars 6 forks source link

potential logic error (`||` vs. `&&`) #46

Closed gammeter closed 3 years ago

gammeter commented 3 years ago

https://github.com/openiolink/io-link-master-shield-hat-sw/blob/b60d9b4059610b7c1cb9fa93252d0520cbdbab4c/src/board/Max14819.cpp#L201

Shouldn't there be a && instead of the ||?

SecurityCheck commented 3 years ago

No the current status is correct. This should continue as long as the communication is still running and time for a timeout has not been reached.