search

openj / core

abandoned, please check out https://github.com/jsoftware/jsource
https://github.com/jsoftware/jsource
118 stars 26 forks source link

Autoconf for merge #12

Closed lemenkov closed 13 years ago

lemenkov commented 13 years ago

Initial commit of autotools. Tested on Linux only.

effbiae commented 13 years ago

looking good. i'll find some time to try this on mingw.

effbiae commented 13 years ago

just tried this on mingw. autoreconf --install succeeds, but build fails (as expected). it just needs the right #define.s i think

lemenkov commented 13 years ago

Could you provide config.log please?

effbiae commented 13 years ago

just sent via email

lemenkov commented 13 years ago

Ok, I can now reproduce this issue, and fortunately it doesn't related to autotools. There is a homebrew naive attempt to detect the system capabilities in js.h which is broken on almost all systems (it makes false assumptions about OS and available headers and features).

Fortunately, that's exactly what autotools were designed for - test the system for required features and create config.h with all necessary defines. So I think we should kill it with the fire (regenerate it with autotools) as soon as these scripts will be merged.

effbiae commented 13 years ago

good, good. please have a look at https://github.com/openj/core/issues (issues 16, 17, 18 and 19) and add your vote.

effbiae commented 13 years ago

hi,

i was just trying your autotools branch (on ubuntu linux)

it seems to build libj.so and it goes to ./.libs/libj.so but

    g@uvm:~/openj/core$ export LD_LIBRARY_PATH=`pwd`/.libs:$LD_LIBRARY_PATH
    g@uvm:~/openj/core$ ./jconsole 
    Load library /home/g/openj/core/libj.so failed.g@uvm:~/openj/core$

and i tried g@uvm:~/openj/core$ sudo make install g@uvm:~/openj/core$ jconsole Load library /usr/local/bin/libj.so failed.g@uvm:~/openj/core$

looks like jconsole is looking or libj.so in the same directory as the exe

ta, jack

smarter commented 13 years ago

looks like jconsole is looking or libj.so in the same directory as the exe

Yup. There's a commit in https://github.com/openj/core/pull/13 to fix that.

lemenkov commented 13 years ago

Thanks for merging! I did some more changes - I'll provide new pull request shortly.