search

openj / core

abandoned, please check out https://github.com/jsoftware/jsource
https://github.com/jsoftware/jsource
118 stars 26 forks source link

`make test` before `make install` #22

Closed effbiae closed 13 years ago

effbiae commented 13 years ago

This patch is mainly about being able to run the test suite after make but before make install

I don't expect this to bet pulled, but i'd like to discuss.

effbiae commented 13 years ago

ahh crap -- it was just the last commit i wanted to talk about.... still learning...

smarter commented 13 years ago

Use "git rebase" to avoid the "Merge branch ..." commits.

effbiae commented 13 years ago

the .libs/ strings here are undesirable.

mainly, i was just trying to get make test working before the libs were installed (libtool puts all libs in .libs/ prior to install)

for both cmake and autotools, the built exes and libs are not put in core/j/bin -- this is part of the make install or, on cmake windows (for example): devenv /build debug /project install j.sln

motivation for this patch was to be able to run jconsole with the DLL in the wrong place for purposes of testing.

plainly, build tool specific code is undesirable in the source.

a potential problem is #defines. for example, as part of the configure process via autotools, HAVE_DLOPEN might be defined. what is the equivalent in CMake? Does CMake have specific standard defines that differ? i mean, does CMake define CMAKE_HAVE_DLOPEN ?

smarter commented 13 years ago

In the CMakeLists.txt there's check_library_exists(dl dlopen "" HAVE_DL), which sets the HAVE_DL cmake variable if dlopen is found. add_definitions() could be used to pass -DHAVE_DLOPEN to gcc.

effbiae commented 13 years ago

to be revised