incorporate effbiae's windows build changes

openj / core

abandoned, please check out https://github.com/jsoftware/jsource

https://github.com/jsoftware/jsource

118 stars 26 forks source link

Closed sofuture closed 13 years ago

sofuture commented 13 years ago

Here you go, this is a lot saner of a commit.

effbiae commented 13 years ago

my eyes say it is good.

i might be a little unsure of #define.ing OPENJ and using it as you have.
i mean, we could #if everywhere we make a change...

but it is a good way of flagging things that we might not be confident of. but it's generally a +1 for me.

sofuture commented 13 years ago

I'm gonna merge this!

effbiae commented 13 years ago

do it :)

On Fri, May 20, 2011 at 10:52 AM, jzellner reply@reply.github.com wrote:

I'm gonna merge this!

Reply to this email directly or view it on GitHub: https://github.com/openj/core/pull/25#issuecomment-1207413