search

openj / core

abandoned, please check out https://github.com/jsoftware/jsource
https://github.com/jsoftware/jsource
118 stars 26 forks source link

minor changes to C source and base bootstrap files for android #29

Closed mdykman closed 12 years ago

mdykman commented 12 years ago

Android implementation additionally requires android-specific Java source to be published as a distinct project.

sofuture commented 12 years ago

Hey, not ignoring this, hope to check it out today or tomorrow.

sofuture commented 12 years ago

Still not ignoring this, have an email out to effbiae to check it out.

effbiae commented 12 years ago

my quick scan says it looks ok. only picked up that you're proposing to include generated files in this patch. it would be nice to have a process that generates these files at build time.

mdykman commented 12 years ago

Jack,

Could you please point me to which generated files you mean? I certainly did intend not to include them but I may have lost track.

On Fri, Feb 10, 2012 at 2:38 AM, jack andrews reply@reply.github.com wrote:

my quick scan says it looks ok.  only picked up that you're proposing to include generated files in this patch.  it would be nice to have a process that generates these files at build time.

Reply to this email directly or view it on GitHub: https://github.com/openj/core/pull/29#issuecomment-3902391

 - michael dykman  - mdykman@gmail.com

 May the Source be with you.

mdykman commented 12 years ago

Ah, of course, the def files, netdefs_XXX.ijs and hostdefs_XXX.ijs

I am torn on that topic. It is something of a pain to generate these. One must compile j-provided C source files with the android developer toolkit to produce Android-compatible executables. Those must then be manually upload to a device or emulator and executed in that environment. It is the output of these executions which become the def files and those must then be 'pulled' back to the building environment for inclusion in the main build. Not easy to automate. At the moment, I'm not even sure it's possible to automate.

I certainly should include the Android.mk files I created to facilitate their building but it requires a little restructurinrg as both hostdefs and netdefs must be built in distinct directories to produce distinct binaries (a constraint of the ADT) where j provides them in a single directory.

In my build environment, I have created distinct directories for them as siblings to the openj base directory (which is to say, they are all in ANDROID_PROJECT_HOME/jni) and put the respective Android.mk file in those folders. If I commit them to open-j, netdefs.c and hostdefs.c are now duplicated within that repo; not good. If I fold them into https://github.com/mdykman/jconsole_for_android (the companion project containing the android specific parts) then the files are duplicated across distinct repositories; even less good.

A master make file which builds libj.so, hostdefs, netdefs as well as the Android-specific stuff would be awkward as the code is spread across 2 distinct repos. open-j must reside within the android project under it's jni/ directory to satisfy the ADT.

I welcome any suggestions.

effbiae commented 12 years ago

hi michael,

you've obviously thought about this, and i don't know android at all.

i vote we pull these changes, and if you can find a better way later, then that's good too.

ta, jack.

On Sat, Feb 11, 2012 at 9:33 AM, Michael Dykman reply@reply.github.com wrote:

Ah, of course, the def files, netdefs_XXX.ijs and hostdefs_XXX.ijs

I am torn on that topic.

sofuture commented 12 years ago

Merged in