Make JavaFx platform configurable

openjfx / javafx-gradle-plugin

Gradle plugin that makes it easy to work with JavaFX 11+

https://openjfx.io/

BSD 3-Clause "New" or "Revised" License

354 stars 62 forks source link

Make JavaFx platform configurable #103

Closed shahzaibj closed 1 year ago

shahzaibj commented 3 years ago

This PR Addresses https://github.com/openjfx/javafx-gradle-plugin/issues/99

Platform can now be configured as follows:

majerm commented 3 years ago

Thank you for PR. I need this functionality too. But mabye it is good write some lines to README file near section with name "4. Cross-platform projects and libraries".

johanvos commented 3 years ago

This is good functionality. @jperedadnr can you review?

jperedadnr commented 3 years ago

@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?

alaznem commented 2 years ago

@shahzaibj As per our contributions guidelines, could you please sign the CLA[https://cla.gluonhq.com/] before we can move forward with this PR?

@shahzaibj : I came here from downstream as an user of the Sparrow wallet, where we're unable to build on Raspberry Pi 4 (arm) because of the JavaFx platform error solely. As @craigraw (the maintainer of sparrow) writes, your/this PR could solve our issues downstream.

As I got the current situation with this PR, the effort to be taken to move forward seems quite low to me: @jperedadnr has requested 3 months ago the singing of the CLA[https://cla.gluonhq.com/] from you.

:question: Could you please decide if you're able to sign the CLA[https://cla.gluonhq.com/] or not and communicate likewise?

:pray: Thanks