openjfx / javafx-gradle-plugin

Gradle plugin that makes it easy to work with JavaFX 11+
https://openjfx.io/
BSD 3-Clause "New" or "Revised" License
347 stars 59 forks source link

Add start script handling for Distributions tasks #127

Open arlaneenalra opened 2 years ago

arlaneenalra commented 2 years ago

This code does two things:

To accomplish this, I abstracted the common behavior in ExecTask into a JavaFXTask base class and added the StartScriptsTask. This is probably not the cleanest implementation but it appears to work in my local testing.

It may be possible to back out the gradle update, but I would have no way to test that.

arlaneenalra commented 2 years ago

@jperedadnr or @abhinayagarwal my apologies if this is a breach of protocol, what's the best way to get reviewers for a pull request?

sschuberth commented 10 months ago

This PR has conflicts now that https://github.com/openjfx/javafx-gradle-plugin/pull/151 was merged.