Open arlaneenalra opened 2 years ago
@jperedadnr or @abhinayagarwal my apologies if this is a breach of protocol, what's the best way to get reviewers for a pull request?
This PR has conflicts now that https://github.com/openjfx/javafx-gradle-plugin/pull/151 was merged.
This code does two things:
CreateStartScripts
configuration in the same way that theJavaExec
task is updated. This allows theassembleDist
task to create usable startup scripts.To accomplish this, I abstracted the common behavior in
ExecTask
into aJavaFXTask
base class and added theStartScriptsTask
. This is probably not the cleanest implementation but it appears to work in my local testing.It may be possible to back out the gradle update, but I would have no way to test that.