openjfx / javafx-maven-plugin

Maven plugin to run JavaFX 11+ applications
Apache License 2.0
371 stars 59 forks source link

Non-modular dependencies not found #10

Open Bobulous opened 5 years ago

Bobulous commented 5 years ago

The javafx-maven-plugin appears unable to see non-modular dependencies.

When called with mvn -X clean javafx:run and the following plugin configuration:

<plugin>
    <groupId>org.openjfx</groupId>
    <artifactId>javafx-maven-plugin</artifactId>
    <version>0.0.1</version>
    <configuration>
        <mainClass>uk.org.bobulous.java.myjavafxproject.MyJavaFXApplication</mainClass>
        <commandlineArgs>-Djdk.gtk.version=2</commandlineArgs>
    </configuration>
</plugin>

The build fails with errors that suggest that the modular project DependencyTDCX is visible to the build process, but the non-modular projects SkunkWorks, JavaUtilities, and DependencyXC are not found (even though their classpaths are shown in the "Classpath" section of the build output.

Output of mvn -X clean javafx:run is attached.

javafx-maven-plugin_error-trace.txt

jperedadnr commented 5 years ago

I'm trying to reproduce this issue, adding a non-modular module and the JavaFX module to a multi modular maven project.

As I add the non-modular project to the module-info, I get that its jar is added to the module path (the module name is inferred via jar name), so I can't reproduce your problem.

Is there any chance you can share your project or setup?