search

openjfx / openjfx-docs

Getting started guide for JavaFX 11
BSD 3-Clause "New" or "Revised" License
95 stars 25 forks source link

Provide getting started document for VS Code #214

Closed jdneo closed 2 years ago

jdneo commented 2 years ago

Signed-off-by: sheche sheche@microsoft.com

jdneo commented 2 years ago

Hi @jperedadnr,

This is the PR to initialize the getting started document for VS Code.

One question: I noticed that the existing screenshots all have a white colored margin as the background, the screenshots in this PR does not have that, do I need to add them? Or could I directly use css margin style?

jdneo commented 2 years ago

@jperedadnr would you mind to take a look at this PR?

jperedadnr commented 2 years ago

Ok, we'll look into it. About screenshots, we typically take them on macOS, which adds this shadow effect, but it is not mandatory.

jdneo commented 2 years ago

Hi @jperedadnr,

We post a tweet on Twitter yesterday about JavaFX support in VS Code, looks like people are really existing about JavaFX support in VS Code. The tweet's PV data looks amazing too:

0d57fbab-9364-4945-a55f-45cdff054e96

It would be really appreciated if the team can get this PR reviewed and merged, which I think can provide more help to the JavaFX and VS Code developers. 😄

abhinayagarwal commented 2 years ago

The screenshots are very close to the paragraph text.

image

Adding the following style to gluon.css makes it look much better:

/* Visual Code */
#IDE-VSCode img {
    padding: 1em;
}

image

jdneo commented 2 years ago

@abhinayagarwal Thank you for reviewing the PR. I've addressed some of the comments.

As of the statements of other Maven dependencies and other Gradle dependencies, I'm ok to remove them.

Waiting for your suggestion and I'll make follow-up actions if needs.