search

openjfx / samples

JavaFX samples to run with different options and build tools
BSD 3-Clause "New" or "Revised" License
578 stars 1.52k forks source link

Update samples #50

Open jperedadnr opened 4 years ago

jperedadnr commented 4 years ago

to take into account Gradle 6.4+ for JDK 14+ and the recently published JavaFX gradle plugin 0.0.9

nlisker commented 7 months ago

@jperedadnr It seems that there's a need to update the examples and the dependency versions. For example, the Gradle version is 5.0 (https://github.com/openjfx/samples/blob/master/IDE/Eclipse/Modular/Gradle/hellofx/gradle/wrapper/gradle-wrapper.properties). Some of them don't work for me, and I see a lot of complaints in issues that weren't addressed. These examples are referenced from the JavaFX website and could be deterring users. Are there plans any to give them a overhaul? If not, I suggest unlinking them from the tutorials.

abhinayagarwal commented 7 months ago

Hi Nir,

Thank you for the nudge. Can you review https://github.com/openjfx/samples/pull/73 ?

nlisker commented 7 months ago

I can review the Eclipse and maybe some of the command line ones.