Add VS Code samples - Githubissues

openjfx / samples

JavaFX samples to run with different options and build tools

BSD 3-Clause "New" or "Revised" License

596 stars 1.52k forks source link

Closed jdneo closed 2 years ago

jdneo commented 2 years ago

Hi JavaFX team, 👋

This PR is to add more JavaFX samples working with Visual Studio Code.

Below sections are added:

Currently the VS Code Java has an issue to work with modular project without the build system. Once the issue is fixed, we will update the samples.

Signed-off-by: sheche sheche@microsoft.com

nickzhums commented 2 years ago

@jperedadnr could you help to review this one? (assuming you are right person) thanks

jperedadnr commented 2 years ago

Thanks for the contribution, we'll have a look shortly.

jdneo commented 2 years ago

Hello @jperedadnr @abhinayagarwal, any chance to take a look at this PR?

jdneo commented 2 years ago

@abhinayagarwal Thanks for reviewing, I've address the comment. Please take a look when you have time, thanks! 😄

jdneo commented 2 years ago

Thank you @jperedadnr, I've updated the PR, please take a look when you have time.

jdneo commented 2 years ago

Could we merge this PR now?

jperedadnr commented 2 years ago

@jdneo Done! Are you planing to do a follow up PR for https://github.com/openjfx/openjfx-docs ?

jdneo commented 2 years ago

Thank you @jperedadnr!

Yes I'll write the document part recently and send a PR for that.