openjournals / inara

Tools to create JOSS/JOSE publishing artifacts
MIT License
27 stars 17 forks source link

Bug in template #17

Closed linuxscout closed 2 years ago

linuxscout commented 2 years ago

Hi, I clone the repo, and try to test makefile on example paper I got this errors:

~/workspace/tests/inara$ make ARTICLE=example/paper.md
INARA_ARTIFACTS_PATH=publishing-artifacts/ pandoc \
  --data-dir=data \
  --resource-path=.:resources:example/ \
  --metadata=article-info-file=resources/default-article-info.yaml \
  --variable=joss \
  --output=publishing-artifacts/paper.pdf \
  example/paper.md
"template" (line 388, column 16):
unexpected "{"
expecting "$endif$"
make: *** [Makefile:33: publishing-artifacts/paper.pdf] Error 5
tarleb commented 2 years ago

Thanks for the report. The most likely cause for this is an outdated pandoc version: newer versions allow to use ${varname} instead of $varname$ in templates. Can you try if updating is enough to resolve the issue?

We should add a note about the minimal pandoc version in the docs.

linuxscout commented 2 years ago

Thank you, I Updated the package, and I passed this error.

Thanks

tarleb commented 2 years ago

Great, that's good to know. I've now added a short section on system requirements to the README.

linuxscout commented 2 years ago

I update the pandoc, but it was compiled with pandoc-citeproc 0.8.0.1 version, when the latest version is pandoc-citeproc 0.15.0.1

tarleb commented 2 years ago

Citation handling was changed sometime around pandoc 2.10, which now has a citeproc processor built-in. The pandoc-citeproc version should no longer matter for that reason.

linuxscout commented 2 years ago

Thank you.