Closed cthoyt closed 2 months ago
@tarleb – would you mind taking a look at this? Unfortunately the current build of Inara is broken for JOSS: https://github.com/openjournals/joss-reviews/issues/6917#issuecomment-2331099794
I'm thinking it might be useful to add the make test
into the CI pipeline to help us be more confident in adding changes in the future, too
I'm thinking it might be useful to add the make test into the CI pipeline to help us be more confident in adding changes in the future, too
We do that already as part of the build pipeline.
@tarleb ah, I see this! perhaps splitting it out into its own chunk would be good, since the image builder workflow fails for PRs since I don't have credentials for dockerhub built in
See #70
@arfon version 1.1.1 is deployed with a fix, build should work now 🤞
Thank you, LGTM. There's a currently a merge conflict, this can be merged after the rebase.
There were two issues in the
prepare-affiliatons.lua
scriptpdf
andpreprint
configurations got lost. This adds them back!