openjournals / inara

Tools to create JOSS/JOSE publishing artifacts
MIT License
30 stars 17 forks source link

Fix affiliation bug #77

Closed cthoyt closed 2 months ago

cthoyt commented 2 months ago

There were two issues in the prepare-affiliatons.lua script

  1. Somehow during the squash/merge process, the part where it got applied in the pdf and preprint configurations got lost. This adds them back!
  2. This PR makes it more robust for string format for affiliation lists. I'm not sure if this was actually an issue before, but I updated the example PDF to contain one of these examples just to be sure.
arfon commented 2 months ago

@tarleb – would you mind taking a look at this? Unfortunately the current build of Inara is broken for JOSS: https://github.com/openjournals/joss-reviews/issues/6917#issuecomment-2331099794

cthoyt commented 2 months ago

I'm thinking it might be useful to add the make test into the CI pipeline to help us be more confident in adding changes in the future, too

see https://github.com/openjournals/inara/pull/78

tarleb commented 2 months ago

I'm thinking it might be useful to add the make test into the CI pipeline to help us be more confident in adding changes in the future, too

We do that already as part of the build pipeline.

cthoyt commented 2 months ago

@tarleb ah, I see this! perhaps splitting it out into its own chunk would be good, since the image builder workflow fails for PRs since I don't have credentials for dockerhub built in

tarleb commented 2 months ago

See #70

xuanxu commented 2 months ago

@arfon version 1.1.1 is deployed with a fix, build should work now 🤞

tarleb commented 2 months ago

Thank you, LGTM. There's a currently a merge conflict, this can be merged after the rebase.