openjournals / jose-old

The Journal of Open Source Education (JOSE) is an educator-friendly journal for publishing computational learning modules & educational software.
http://jose.theoj.org
MIT License
94 stars 10 forks source link

Submission Pulldown for Selection of Article Type #1

Closed katyhuff closed 6 years ago

katyhuff commented 7 years ago

The authors will need to self-identify which type of article they are submitting (lesson material, or software). We'll need to add that to the submission form so that the bot can pull up the proper review checklist.

labarba commented 7 years ago

This is two tasks:

  1. adding the drop-down "Submission Type" to the web form (easy task)
  2. modifying whedon so it knows which review checklist to print on the "Review" issue (not so easy?)

Perhaps task 2 can be made easier by delegating to the editor that commands whedon to start the review with choosing the submission type. Something like:

@whedon start review -type oer magic-word=bananas vs @whedon start review -type tool magic-word=bananas

Leaves a margin for human error, but a minor risk I think.

labarba commented 7 years ago

@arfon Care to comment on this?

arfon commented 7 years ago

@arfon Care to comment on this?

Sure thing. I don't think Whedon needs to know anything about this as the review checklist is actually described in the JOSS (or JOSE in this case) we application: https://github.com/openjournals/jose/blob/master/app/views/shared/review_body.erb

So we need to adapt the database schema to add a submission_type field to thepapers table. Then we can add some view logic to allow people to pick which type of material they're submitting.

When the editor starts the review (@whedon start review) we can just have a case statement in the review_body.erb to make sure the correct review body is written to the GitHub issue.

Edit: Do you have someone to make these changes?

labarba commented 7 years ago

Ah, much better!

moorepants commented 7 years ago

Do you have someone to make these changes?

I think we need an editor that knows Ruby...

labarba commented 7 years ago

@arfon : We do not have anyone on hand to make these changes.

labarba commented 6 years ago

This was completed as part of the whedon upgrade. See: https://github.com/openjournals/joss/issues/329