search

openjournals / jose-reviews

Reviews for the Journal of Open Source Education (JOSE)
http://jose.theoj.org
Creative Commons Zero v1.0 Universal
33 stars 4 forks source link

[REVIEW]: Auto-eD: A visual learning tool for automatic differentiation #161

Closed whedon closed 2 years ago

whedon commented 2 years ago

Submitting author: !--author-handle-->@lindseysbrown<!--end-author-handle-- (Lindsey Brown) Repository: https://github.com/lindseysbrown/Auto-eD Branch with paper.md (empty if default branch): master Version: v1.0.2 Editor: !--editor-->@labarba<!--end-editor-- Reviewer: @rasbt, @Atcold Archive: 10.5281/zenodo.6800009 Paper kind: software

:warning: JOSE reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/e485c9012c66d61d25f9a2c8008d441d"><img src="https://jose.theoj.org/papers/e485c9012c66d61d25f9a2c8008d441d/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/e485c9012c66d61d25f9a2c8008d441d/status.svg)](https://jose.theoj.org/papers/e485c9012c66d61d25f9a2c8008d441d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rasbt & @Atcold, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/jose-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @labarba know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @rasbt

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @Atcold

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 2 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 2 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1907.07587 is OK
- 10.1109/5.58337 is OK

MISSING DOIs

- None

INVALID DOIs

- 10.5555/3122009.3242010 is INVALID
whedon commented 2 years ago

:wave: @openjournals/jose-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/jose-papers/pull/99

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/jose-papers/pull/99, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
labarba commented 2 years ago

Hmm. It doesn't look like JMLR mints Does. Do you want to instead link to the URL? url = {http://jmlr.org/papers/v18/17-468.html}

lindseysbrown commented 2 years ago

https://dl.acm.org/doi/abs/10.5555/3122009.3242010

This doi seems to link to the source? I can do whatever you prefer.

labarba commented 2 years ago

Interesting. The DOI itself does not resolve at http://doi.org/10.5555/3122009.3242010

EDIT: that is the link that will be automatically added in compiling the PDF, so I think it is best to add it as URL and not a DOI.

lindseysbrown commented 2 years ago

Ok. Should I create a new release with the doi changed to url???

labarba commented 2 years ago

No need. The release and archive are really targeting the package. The paper will be deposited by JOSE with its own DOI and will be archived too.

lindseysbrown commented 2 years ago

Ok, then I've committed the new bib file.

labarba commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

labarba commented 2 years ago

@whedon accept deposit=true

whedon commented 2 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 2 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSE! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/jose-papers/pull/100
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/jose.00161
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

labarba commented 2 years ago

Congratulations, @lindseysbrown, your JOSE paper is published!

Huge thanks to our Reviewers: @rasbt, @Atcold — we couldn't do this without you 🙏

whedon commented 2 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://jose.theoj.org/papers/10.21105/jose.00161/status.svg)](https://doi.org/10.21105/jose.00161)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/jose.00161">
  <img src="https://jose.theoj.org/papers/10.21105/jose.00161/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://jose.theoj.org/papers/10.21105/jose.00161/status.svg
   :target: https://doi.org/10.21105/jose.00161

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Education is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

rasbt commented 2 years ago

Wow, awesome, congrats @lindseysbrown, @rachelmoonstar, and David Sondak! 🎉🎊🍾

Atcold commented 2 years ago

🥳🥳🥳

arfon commented 11 months ago

@labarba – the submitting author contacted me (on admin@theoj.org) to ask for an update to their paper (see this change: https://github.com/lindseysbrown/Auto-eD/commit/7c1eef58e5d568c739c4902b7b3706ae7a22bc92). This should be possible with a simple @editorialbot reaccept but before I do this I wanted to get an explicit :+1: from you.

Atcold commented 11 months ago

The URL points to a broken page. Update not approved.

lindseysbrown commented 11 months ago

I am able to view the updated url: https://autoed.onrender.com Note that render can be slow to spin up on the free tier. (The update was from the heroku link which is broken.)

Atcold commented 11 months ago

When I tried it was not working. Now it works.