openjournals / jose-reviews

Reviews for the Journal of Open Source Education (JOSE)
http://jose.theoj.org
Creative Commons Zero v1.0 Universal
33 stars 4 forks source link

[REVIEW]: An Active Learning Laboratory Manual for Teaching a Contemporary Undergraduate Operating System Course #162

Closed whedon closed 1 year ago

whedon commented 2 years ago

Submitting author: @saverioperugini (Saverio Perugini) Repository: https://bitbucket.org/saverioperugini/operating-systems-lab-manual/ Version: JOSE_v1.0.0 Editor: @csev Reviewer: @MattForshaw, @georgiastuart Archive: 10.5281/zenodo.7200056

:warning: JOSE reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode".

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/c75d974e8d532948840318176362cbb1"><img src="https://jose.theoj.org/papers/c75d974e8d532948840318176362cbb1/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/c75d974e8d532948840318176362cbb1/status.svg)](https://jose.theoj.org/papers/c75d974e8d532948840318176362cbb1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@MattForshaw & @georgiastuart, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/jose-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csev know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Review checklist for @MattForshaw

Conflict of interest

Code of Conduct

General checks

Documentation

Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)

JOSE paper

Review checklist for @georgiastuart

Conflict of interest

Code of Conduct

General checks

Documentation

Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)

JOSE paper

whedon commented 2 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @MattForshaw, @georgiastuart it looks like you're currently assigned to review this paper :tada:.

:warning: JOSE reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/jose-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/jose-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 2 years ago

Wordcount for paper.md is 1842

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1145/3287324.3293734 may be a valid DOI for title: Developing a Contemporary and Innovative Operating Systems Course
- 10.1145/3287324.3293756 may be a valid DOI for title: An Interactive, Graphical Simulator for Teaching Operating Systems

INVALID DOIs

- None
whedon commented 2 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.25 s (225.6 files/s, 48545.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                             44           2626            796           8094
Markdown                         2             52              0            277
C                                4             17              3            105
JSON                             1              0              0             30
make                             2              8              1             23
C/C++ Header                     1              2              4              7
Korn Shell                       1              2              0              3
HTML                             1              0              0              1
-------------------------------------------------------------------------------
SUM:                            56           2707            804           8540
-------------------------------------------------------------------------------

Statistical information for the repository 'cfceabb6e2c480e53acf05be' was
gathered on 2022/02/25.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Saverio Perugini                 1           138              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Saverio Perugini            138          100.0          0.0                5.07
whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

labarba commented 2 years ago

@MattForshaw, @georgiastuart — Thank you for agreeing to review for JOSE! This is where the action happens: work your way through the review checklist, feel free to ask questions or post comments here, and also open issues in the submission repository as needed. Godspeed! 🚀

labarba commented 2 years ago

@csev I don't know anything about operating systems, so I'm grateful for your guidance of this review process 🙏

csev commented 2 years ago

While I am not a reviewer per se - I did read the paper, checked it our from butbucket and ran LaTeX and it worked and then I looked at the resulting PDF - and that was fine. One recommendation - Add the instructions on how to checkout and build to the README.md file in the repo. It was kind of weird going back and forth between the paper and the repo. :)

saverioperugini commented 2 years ago

Done.  Thanks!

Best regards,

Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Feb 25, 2022, 12:23 PM -0500, Charles Severance @.***>, wrote:

While I am not a reviewer per se - I did read the paper, checked it our from butbucket and ran LaTeX and it worked and then I looked at the resulting PDF - and that was fine. One recommendation - Add the instructions on how to checkout and build to the README.md file in the repo. It was kind of weird going back and forth between the paper and the repo. :) — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

whedon commented 2 years ago

:wave: @georgiastuart, please update us on how your review is going (this is an automated reminder).

whedon commented 2 years ago

:wave: @MattForshaw, please update us on how your review is going (this is an automated reminder).

georgiastuart commented 2 years ago

Going well! I hope to have my review up next week.

labarba commented 2 years ago

hi @MattForshaw, @georgiastuart – How is it going with your reviews? Could you give us a quick update? Let us know if you have any questions! 🙏

MattForshaw commented 2 years ago

I would like to thank the authors for preparing their submission to JOSE. In my opinion, it is a submission of significant merit, and I have just two points I would like to pick up on in relation to the criteria outlined above.

georgiastuart commented 2 years ago

Apologies for the delay. I'm almost finished reviewing.

saverioperugini commented 2 years ago

Hi,

I was curious if there are any updates on this submission?

Thank you and best regards, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On May 10, 2022, 10:56 AM -0400, Saverio Perugini @.***>, wrote:

Hi,

Any updates on this submission?

Thank you. Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Apr 28, 2022, 8:34 AM -0400, Georgia Stuart @.***>, wrote:

Apologies for the delay. I'm almost finished reviewing. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

georgiastuart commented 2 years ago

@saverioperugini have you had a chance to address @MattForshaw's comments?

saverioperugini commented 2 years ago

I wrote the following message on April 6 to clarify what changes needed to be made and I never received a reply:

@.*** Within the "Documentation" criteria, a centralised Statement of Need in the documentation might be beneficial. The need for the course, in terms of the target audience and the identified gap, is made clear throughout the actual materials.

@saverioperugini: Are you suggesting we copy the Statement of Need section that is in paper.md to the README.md ?

@.*** I have just one checkbox unticked under "JOSE paper". More could be done within the JOSE paper itself to tell the "story" of how the authors came to develop the tool.

The section titled “Larger Scope” in paper.md briefly outlines the story.  Do you want that section to be expanded?  Happy to do so.

Thanks, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Apr 6, 2022, 11:40 AM -0400, Matthew Forshaw @.***>, wrote:

Within the "Documentation" criteria, a centralised Statement of Need in the documentation might be beneficial. The need for the course, in terms of the target audience and the identified gap, is made clear throughout the actual materials.

Are you suggesting we copy the Statement of Need section that is in paper.md to the README.md ?

I have just one checkbox unticked under "JOSE paper". More could be done within the JOSE paper itself to tell the "story" of how the authors came to develop the tool.

The section titled “Larger Scope” in paper.md briefly outlines the story.  Do you want that section to be expanded?  Happy to do so.

 The expertise of the authorship is entirely evident, however. :)

saverioperugini commented 2 years ago

Hi,

Any updates?

Thanks, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Jun 7, 2022, 2:43 PM -0400, Saverio Perugini @.***>, wrote:

I wrote the following message on April 6 to clarify what changes needed to be made and I never received a reply:

@.*** Within the "Documentation" criteria, a centralised Statement of Need in the documentation might be beneficial. The need for the course, in terms of the target audience and the identified gap, is made clear throughout the actual materials.

@saverioperugini: Are you suggesting we copy the Statement of Need section that is in paper.md to the README.md ?

@.*** I have just one checkbox unticked under "JOSE paper". More could be done within the JOSE paper itself to tell the "story" of how the authors came to develop the tool.

The section titled “Larger Scope” in paper.md briefly outlines the story.  Do you want that section to be expanded?  Happy to do so.

Thanks, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Apr 6, 2022, 11:40 AM -0400, Matthew Forshaw @.***>, wrote:

Within the "Documentation" criteria, a centralised Statement of Need in the documentation might be beneficial. The need for the course, in terms of the target audience and the identified gap, is made clear throughout the actual materials.

Are you suggesting we copy the Statement of Need section that is in paper.md to the README.md ?

I have just one checkbox unticked under "JOSE paper". More could be done within the JOSE paper itself to tell the "story" of how the authors came to develop the tool.

The section titled “Larger Scope” in paper.md briefly outlines the story.  Do you want that section to be expanded?  Happy to do so.

 The expertise of the authorship is entirely evident, however. :)

georgiastuart commented 2 years ago

@saverioperugini Odd, I don't see your April 6th message. I can't speak for @MattForshaw, but I think putting your statement of need in README.md is reasonable.

I don't see DOIs on your references. I believe JOSE requires that.

labarba commented 2 years ago

@whedon generate pdf

whedon commented 2 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

labarba commented 2 years ago

@whedon check references

whedon commented 2 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1145/3287324.3293734 may be a valid DOI for title: Developing a Contemporary and Innovative Operating Systems Course
- 10.1145/3287324.3293756 may be a valid DOI for title: An Interactive, Graphical Simulator for Teaching Operating Systems

INVALID DOIs

- None
labarba commented 2 years ago

@MattForshaw – are you satisfied with the revision?

@saverioperugini – please add DOIs for the references that have them.

saverioperugini commented 2 years ago

Hi,

In my latest commit (4 minutes ago), I

• Added the Statement of Need to README.md; • added DOIs to PAPER/paper.bib; • and updated affiliations in PAPER/paper.md

Note:  I added DOIs in paper.bib for the cited papers that have DOIs; not all of them do.

Thank you and best regards,

Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Jun 14, 2022, 2:39 PM -0400, Lorena A. Barba @.***>, wrote:

@MattForshaw – are you satisfied with the revision? @saverioperugini – please add DOIs for the references that have them. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

saverioperugini commented 2 years ago

Hi,

Were the changes in my latest commit OK?

Thanks, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. Le 14 juin 2022 à 2:39 PM -0400, Lorena A. Barba @.***>, a écrit :

@MattForshaw – are you satisfied with the revision? @saverioperugini – please add DOIs for the references that have them. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

labarba commented 2 years ago

@MattForshaw — You have a couple of unchecked items in your review checklist. The author has made some mods in response to review comments. Could you pop in to have a final look, and let us know your recommendation? 🙏

labarba commented 2 years ago

@georgiastuart — You have a couple of unchecked items in your review checklist, as well. In a comment above, it sounded you were satisfied with one pending item (the Statement of Need). Can you let us know if you are ready to recommend acceptance, and if so, check your final items? 🙏

saverioperugini commented 2 years ago

Hi,

Is there any thing remaining that you need me to do on my end?

Thanks so much, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Jun 17, 2022, 6:21 AM -0400, Lorena A. Barba @.***>, wrote:

@georgiastuart — You have a couple of unchecked items in your review checklist, as well. In a comment above, it sounded you were satisfied with one pending item (the Statement of Need). Can you let us know if you are ready to recommend acceptance, and if so, check your final items? 🙏 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

saverioperugini commented 2 years ago

Hi,

Any updates on this?

Thank you and best regards, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Jun 17, 2022, 6:21 AM -0400, Lorena A. Barba @.***>, wrote:

@georgiastuart — You have a couple of unchecked items in your review checklist, as well. In a comment above, it sounded you were satisfied with one pending item (the Statement of Need). Can you let us know if you are ready to recommend acceptance, and if so, check your final items? 🙏 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

georgiastuart commented 2 years ago

@labarba I'm satisfied with the updates!

labarba commented 2 years ago

Thank you, @georgiastuart !

@MattForshaw – you have two unchecked items in your review checklist. Are you happy to check those off?

saverioperugini commented 2 years ago

Hi,

Any new updates this?

Thank you so much, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Jul 5, 2022, 5:09 PM -0400, Lorena A. Barba @.***>, wrote:

Thank you, @georgiastuart ! @MattForshaw – you have two unchecked items in your review checklist. Are you happy to check those off? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

labarba commented 2 years ago

hi @MattForshaw 👋 It looks like we are needing just two more items checked off your review list here? Could you take a new look? Thanks!

MattForshaw commented 2 years ago

Good morning everyone.

Please forgive the hold-up on my part; i wasn't receiving alerts from this thread.

Thanks very much to the authors for the further work; these are excellent and fully address my queries.

Best wishes, Matt

labarba commented 2 years ago

hi @saverioperugini 👋 We're in good shape here! Can you now make a tagged release in the repo and report the version number here?

Then, make a deposit on Zenodo and report the archive DOI here. Cheers!

labarba commented 2 years ago

@csev – As the handling editor, could you give the paper one final read-through, and request any fixes, and if ready run the command @whedon recommend-accept — thank you! 🙏

csev commented 2 years ago

This looks good to me. I checked it out and made the manual.

csev commented 2 years ago

@whedon recommend-accept

whedon commented 2 years ago

No archive DOI set. Exiting...

csev commented 2 years ago

So @labarba - I think I did the thing - but it did not do its thing :)

labarba commented 2 years ago

ah, yes... We need to ask the authors to make a tagged release on their repo, and report the version here (then run @whedon set v.0.0.0 as version), and to make a Zenodo deposit and report the archive DOI here (then run @whedon set <doi> as archive).

saverioperugini commented 2 years ago

Hi,

I will create the tagged release in BitBucket and post the version # here.

Also, since Zenodo cannot link directly to BitBucket the way it can link directly to GitHub, do you recommend I simply download a zip of the repository from BitBucket and upload that archive to Zenodo?

Thanks so much, Saverio

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Aug 26, 2022, 2:01 PM -0400, Lorena A. Barba @.***>, wrote:

ah, yes... We need to ask the authors to make a tagged release on their repo, and report the version here (then run @whedon set v.0.0.0 as version), and to make a Zenodo deposit and report the archive DOI here (then run @whedon set as archive). — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

saverioperugini commented 2 years ago

@whedon generate pdf

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Aug 26, 2022, 2:01 PM -0400, Lorena A. Barba @.***>, wrote:

ah, yes... We need to ask the authors to make a tagged release on their repo, and report the version here (then run @whedon set v.0.0.0 as version), and to make a Zenodo deposit and report the archive DOI here (then run @whedon set as archive). — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

whedon commented 2 years ago

PDF failed to compile for issue #162 with the following error:

 /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:204:in `block in parse_authors': Author (Adam R. Bryant) is missing affiliation (RuntimeError)
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in `each'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in `parse_authors'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:93:in `initialize'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `new'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in `set_paper'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:58:in `prepare'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
    from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
    from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:131:in `<top (required)>'
    from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
    from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'
saverioperugini commented 2 years ago

Hi,

I had to remove the affiliations for two authors because (as far as I know) they are no longer in academia, and I don't have new contact info for them.

However, without affiliation information the paper will not compile.

Can you recommend a workaround?

thanks so much,

Saverio

On 8/31/22 7:41 AM, whedon wrote:

PDF failed to compile for issue #162 https://github.com/openjournals/jose-reviews/issues/162 with the following error:

|/app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:204:in block in parse_authors': Author (Adam R. Bryant) is missing affiliation (RuntimeError) from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in each' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:202:in parse_authors' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon.rb:93:in initialize' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in new' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/lib/whedon/processor.rb:38:in set_paper' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:58:in prepare' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-c5c16aedb3d6/bin/whedon:131:in <top (required)>' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in

' |

— Reply to this email directly, view it on GitHub https://github.com/openjournals/jose-reviews/issues/162#issuecomment-1232824582, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPGXGETQYW3MUSEDFQ7BGDV35AFHANCNFSM5PKU3JBQ. You are receiving this because you were mentioned.Message ID: @.***>

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 @.*** WWW:http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender.

labarba commented 2 years ago

hi @saverioperugini — presumably, they were affiliated when the work reported in the paper was done, so it is correct to list their (past) affiliation there. You can add perhaps a footnote to say that they graduated, retired, or otherwise moved on.

saverioperugini commented 2 years ago

Hi,

Thanks.  Will do.

Saverio

On 9/1/22 7:16 AM, Lorena A. Barba wrote:

hi @saverioperugini https://github.com/saverioperugini — presumably, there were affiliated when the work reported in the paper was done, so it is correct to list their (past) affiliation there. You can add perhaps a footnote to say that they graduated, retired, or otherwise moved on.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/jose-reviews/issues/162#issuecomment-1234133742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPGXGF42Q77H4GRUNTN5SLV4CF7PANCNFSM5PKU3JBQ. You are receiving this because you were mentioned.Message ID: @.***>

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

New book: Programming Languages: Concepts and Implementation https://www.jblearning.com/catalog/productdetails/9781284222722

CONFIDENTIALITY NOTICE

The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender.

saverioperugini commented 2 years ago

@whedon generate pdf

On 8/31/22 7:40 AM, Saverio Perugini wrote:

@whedon generate pdf

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

CONFIDENTIALITY NOTICE The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender. On Aug 26, 2022, 2:01 PM -0400, Lorena A. Barba @.***>, wrote:

ah, yes... We need to ask the authors to make a tagged release on their repo, and report the version here (then run @. set v.0.0.0 as version|), and to make a Zenodo deposit and report the archive DOI here (then run @. set as archive|).

— Reply to this email directly, view it on GitHub https://github.com/openjournals/jose-reviews/issues/162#issuecomment-1228773068, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPGXGECBHQDL5FDC2JXWW3V3EBAPANCNFSM5PKU3JBQ. You are receiving this because you were mentioned.Message ID: @.***>

-- Saverio Perugini, Ph.D. Professor Department of Computer Science University of Dayton 300 College Park Dayton, OH 45469-0280 Tel: +1 (937) 229-4079 Fax: +1 (937) 229-2193 E-mail: @.*** WWW: http://academic.udayton.edu/SaverioPerugini/

New book: Programming Languages: Concepts and Implementation https://www.jblearning.com/catalog/productdetails/9781284222722

CONFIDENTIALITY NOTICE

The information contained in this electronic message is confidential and intended only for the use of the individual or entity named above. If the reader of this message is not the intended recipient, you are hereby notified that any dissemination, distribution, or copying of this e-mail or any of its components is strictly prohibited. If you have received this email in error, please "reply" to the sender.