openjournals / jose-reviews

Reviews for the Journal of Open Source Education (JOSE)
http://jose.theoj.org
Creative Commons Zero v1.0 Universal
33 stars 4 forks source link

[PRE REVIEW]: Special relativity in R: the lorentz package #187

Closed whedon closed 1 year ago

whedon commented 1 year ago

Submitting author: @RobinHankin (Robin Hankin) Repository: https://github.com/RobinHankin/lorentz Version: 1.1-0 Editor: @arm61 Reviewers: @HaoZeke, @IanHawke Managing EiC: Jordan Gorzalski

:warning: JOSE reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/316a824a674ee61d79bd0bdb07d07ba1"><img src="https://jose.theoj.org/papers/316a824a674ee61d79bd0bdb07d07ba1/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/316a824a674ee61d79bd0bdb07d07ba1/status.svg)](https://jose.theoj.org/papers/316a824a674ee61d79bd0bdb07d07ba1)

Author instructions

Thanks for submitting your paper to JOSE @RobinHankin. Currently, there isn't an JOSE editor assigned to your paper.

@RobinHankin if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 1 year ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSE reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 1 year ago

Wordcount for paper.md is 765

whedon commented 1 year ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.07 s (408.5 files/s, 81019.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              1              1           2693
R                               14            310             76           1210
Markdown                         3             72              0            419
TeX                              5             49              0            414
Rmd                              4            122            243            108
YAML                             1              6              1             16
make                             1              2              0              8
-------------------------------------------------------------------------------
SUM:                            29            562            321           4868
-------------------------------------------------------------------------------

Statistical information for the repository '4ce31e3b33b10eefbcbe7e0f' was
gathered on 2022/12/20.
No commited files with the specified extensions were found.
whedon commented 1 year ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 1 year ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/ARXIV.2012.15149 is OK
- 10.48550/ARXIV.2212.07005 is OK
- 10.48550/ARXIV.1812.11589 is OK
- 10.21105/jose.00091 is OK

MISSING DOIs

- 10.1007/bf02550347 may be a valid DOI for title: Thomas precession: its underlying gyrogroup axioms and their use in hyperbolic geometry and relativistic physics
- 10.1063/1.168517 may be a valid DOI for title: Teaching special relativity with a computer
- 10.1119/1.4938057 may be a valid DOI for title: Visualizing relativity: the OpenRelativity project
- 10.1002/andp.19053220607 may be a valid DOI for title: Über einen die Erzeugung und Verwandlung des Lichtes betreffenden heuristischen Gesichtspunkt
- 10.1007/978-94-015-3445-1_5 may be a valid DOI for title: Electromagnetic phenomena in a system moving with any velocity smaller than that of light
- 10.1007/978-3-663-19510-8_9 may be a valid DOI for title: Kosmologische Betrachtungen zur allgemeinen Relativitätstheorie

INVALID DOIs

- None
RobinHankin commented 1 year ago

@whedon commands

whedon commented 1 year ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
RobinHankin commented 1 year ago

Hello, not sure if a human reads this. My suggestions for reviewers would be:

  1. Markus P\"ossel poessel@hda-hd.de - influential worker in the field of relativity education
  2. Ian Hawke I.Hawke@soton.ac.uk - editor for a previous JOSE paper of mine which dealt with SR
labarba commented 1 year ago

@arm61 — might you be able to edit this submission? As this would be your first editing assignment, you can count of me to help along the way. Let me know! (If you're ready to take it on, you can run @whedon assign me as editor right here!)

labarba commented 1 year ago

We still do not have an assigned handling editor, but I wonder if we can entice Gabriele Bozzola, @Sbozzolo, to help us as a reviewer? (By complete coincidence, he just followed me on Fosstodon, ha ha! I followed back ☺️)

Sbozzolo commented 1 year ago

Hi @labarba, unfortunately R falls outside of my expertise. So, I think I wouldn't be able to provide an insightful review, but I will be available to answer any question on the science that you or other reviewers might have.

labarba commented 1 year ago

Thanks for popping in here, @Sbozzolo ! Appreciate it. It looked like a lucky strike when I saw you are a numerical relativist. Do you know anyone who could help us with this review?

Sbozzolo commented 1 year ago

Thanks for popping in here, @Sbozzolo ! Appreciate it. It looked like a lucky strike when I saw you are a numerical relativist. Do you know anyone who could help us with this review?

I'd be happy to help, but language is a barrier here. And, in general, I suspect it will be tough to find someone in the relativity and gravitational physics community, since we use primarily Python, Julia, C/C++, and Fortran. From a cursory look at this package, my impression is that it does not implement very sophisticated relativistic calculations, so you probably don't need a domain expert to follow what is going on (the paper itself claims that the package is meant to be accessible to undergraduate students).

One person that I see in the list of volunteers for JOSE is HaoZeke, who lists R as one of their preferred languages and molecular dynamics simulations as one of their topics (which suggests a physics background).

From the JOSS list, I can see AlexAxthelm, which lists R and "physics, education" as their interests. This is the only partial match I found in the first 750 lines of the document, which gives you an idea of how niche is this combination of programming language and topic.

arm61 commented 1 year ago

Happy to handle the editing of this, but on annual leave until the 3rd so can pick it up then.

arm61 commented 1 year ago

@whedon assign me as editor

whedon commented 1 year ago

OK, the editor is @arm61

arm61 commented 1 year ago

Hey, @HaoZeke! Would you be interested in helping out and reviewing this work?

HaoZeke commented 1 year ago

Hi @arm61, happy to help out, but I'm a little backlogged, so I might get to this after the 15th at the earliest. If that's alright, I took a preliminary peek at the code-base and I will be able to handle the technical (R) review as well as the physics (at the level hinted at in the paper).

arm61 commented 1 year ago

Fantastic thanks @HaoZeke! I will hunt a bit today for a second reviewer.

arm61 commented 1 year ago

@whedon assign @HaoZeke as reviewer

whedon commented 1 year ago

OK, @HaoZeke is now a reviewer

arm61 commented 1 year ago

Still working on finding a second reviewer. @RobinHankin do you know of others working in physics with experience in R?

RobinHankin commented 1 year ago

Hello Andrew, I have to say that the intersection between relativistic physics and R is almost nonexistent [a situation I hope to improve with this submission!]. You might ask Zurab Silagadze, @.> who I have been discussing the work with. also Rachel E. Scherr < @.> and Andrew Harris @.***> who work in physics education and astronomy in R respectively.

Best wishes

Robin

-- Robin K. S. Hankin Associate Professor, computational statistics

On Fri, Jan 20, 2023 at 9:54 PM Andrew McCluskey @.***> wrote:

Still working on finding a second reviewer. @RobinHankin https://github.com/RobinHankin do you know of others working in physics with experience in R?

— Reply to this email directly, view it on GitHub https://github.com/openjournals/jose-reviews/issues/187#issuecomment-1398085200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFZUVMO3MICMKP7VDEHM3WTJHCXANCNFSM6AAAAAATERXVYU . You are receiving this because you were mentioned.Message ID: @.***>

arm61 commented 1 year ago

Just am update that I am still working on finding a second reviewer!

RobinHankin commented 1 year ago

thanks for this, I appreciate it!

with best wishes

Robin

Robin K. S. Hankin Associate Professor, computational statistics

On Thu, Feb 9, 2023 at 12:38 AM Andrew McCluskey @.***> wrote:

Just am update that I am still working on finding a second reviewer!

— Reply to this email directly, view it on GitHub https://github.com/openjournals/jose-reviews/issues/187#issuecomment-1422457475, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFFZUXZVIGVHZUVIUILZWLWWOAT3ANCNFSM6AAAAAATERXVYU . You are receiving this because you were mentioned.Message ID: @.***>

arm61 commented 1 year ago

I am pleased to say that we have a second reviewer!

arm61 commented 1 year ago

@whedon add @IanHawke as reviewer

whedon commented 1 year ago

OK, @IanHawke is now a reviewer

arm61 commented 1 year ago

@whedon start review

whedon commented 1 year ago

OK, I've started the review over in https://github.com/openjournals/jose-reviews/issues/196.