openjournals / jose-reviews

Reviews for the Journal of Open Source Education (JOSE)
http://jose.theoj.org
Creative Commons Zero v1.0 Universal
33 stars 4 forks source link

[REVIEW]: An R reproducibility toolkit for the practical researcher #260

Open editorialbot opened 2 months ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@paocorrales<!--end-author-handle-- (Paola Corrales) Repository: https://github.com/eliocamp/reproducibility-with-r/ Branch with paper.md (empty if default branch): Version: v1.2.0 Editor: !--editor-->@yabellini<!--end-editor-- Reviewers: @Aariq, @luisDVA Archive: Pending Paper kind: learning module

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/a8d8bf5fd7a3b4d169121fedd9994f67"><img src="https://jose.theoj.org/papers/a8d8bf5fd7a3b4d169121fedd9994f67/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/a8d8bf5fd7a3b4d169121fedd9994f67/status.svg)](https://jose.theoj.org/papers/a8d8bf5fd7a3b4d169121fedd9994f67)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@Aariq, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html. Any questions/concerns please let @yabellini know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @Aariq

📝 Checklist for @luisDVA

editorialbot commented 2 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.cogpsych.2010.05.004 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: The Turing Way: Sharing the Responsibility of Repr...
- No DOI given, and none found for title: Spaced Practice

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None
editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.84 s (557.7 files/s, 165788.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              2              1              0          53770
HTML                           152          14984            166          22910
SVG                              7              1              3          19636
Sass                            98           1793            244          11009
Markdown                        78           1551              0           4131
JavaScript                      57            942            982           3426
XML                             26            156              0           1200
CSS                             21            139             76            789
TeX                              4             42             30            371
TOML                             4             33             64            305
R                                5             24            142             49
JSON                             5              0              0             45
YAML                             5              0              1             23
Rmd                              5            111            277              6
-------------------------------------------------------------------------------
SUM:                           469          19777           1985         117670
-------------------------------------------------------------------------------

Commit count by author:

   145  Elio Campitelli
    42  Pao
    28  Pao Corrales
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 1073

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

🔴 License found: Creative Commons Attribution 4.0 International (Not OSI approved)

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Aariq commented 2 months ago

Review checklist for @Aariq

Conflict of interest

Code of Conduct

General checks

Documentation

Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)

JOSE paper

These are great materials and the short paper introduces them well. I teach a workshop series that covers similar topics and I'm very excited to adopt some of the materials. I think the guide is written very thoughtfully with their target audience in mind. I especially appreciated the discussion of what reproducibility is and how it is not necessarily related to correctness and isn't a binary. As I was going through the materials on reproducibility.rocks, I opened a few minor issues:

These issues mostly relate to content that is slightly out of date. I'll also note that while it is true that Quarto is still rapidly evolving, I think very soon (if not already) it will be worth it to teach Quarto instead of RMarkdown for reproducible scientific manuscripts and reports. RMarkdown and the rticles package certainly aren't going away anytime soon, but some of the frustrations I've encountered writing manuscripts in RMarkdown have been solved in Quarto—e.g. cross references to equations, images, code chunks, and other arbitrary sections—and I don't think Posit plans to actively develop RMarkdown going forwards. The authors may want to consider prioritizing an update to the reproducible reporting section in the next revision of these materials, although I do not think this update is necessary for acceptance of the manuscript.

eliocamp commented 2 months ago

Thanks for the review and the open issues. I've fixed 3/4. The missing one seems to be a limitation of the theme we're using for the website. I've open an issue in that repository to see what we can do.

And yes on quarto. We hadn't looked at the list of available journal templates for a while, so we didn't know it was so large (although not as large as rticles). We would need to look how to use a custom LaTeX template with quarto.

yabellini commented 2 months ago

@Aariq thank you so much for your review.

yabellini commented 1 month ago

@editorialbot add @luisDVA as reviewer

editorialbot commented 1 month ago

@luisDVA added to the reviewers list!

yabellini commented 1 month ago

Hello @luisDVA, thank you so much for agreeing to review this proposal 🙏 .

I added you as a reviewer. You can generate your checklist by calling our bot:

@ editorialbot generate my checklist

paocorrales commented 1 month ago

Hello! We'll be teaching the workshop this week and are making the usual checks and updates to the material. We haven't changed anything big, just broken links and small additions. I wanted to mention it here in case anyone is currently visiting the web or the repo!

luisDVA commented 3 weeks ago

Review checklist for @luisDVA

Conflict of interest

Code of Conduct

General checks

Documentation

Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)

JOSE paper