Closed whedon closed 5 years ago
PDF failed to compile for issue #35 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 14 0 14 0 0 48 0 --:--:-- --:--:-- --:--:-- 48
pandoc-citeproc: reference Meisel2010 not found
pandoc-citeproc: reference Meisel2010 not found
pandoc-citeproc: reference sandvik not found
pandoc-citeproc: reference rudolph1998 not found
pandoc-citeproc: reference sandvik not found
pandoc-citeproc: reference ohara1997 not found
pandoc-citeproc: reference Meisel2010 not found
pandoc-citeproc: reference Meisel2010 not found
pandoc-citeproc: reference meir2007 not found
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:44:in make_citation': undefined method
has_field?' for #block in generate_citations' from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in
each'
from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:29:in
generate_citations'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:214:in generate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:91:in
compile'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:76:in compile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in
run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in
dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:113:in
<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
Oops, forgot to push my updated .bib file. And because all my references in the vignettes and website build locally before pushing, this is the first step where that would be caught. I've pushed it now. Sorry all!
@wrightaprilm okay, no problem, let's try this again.
@whedon accept
Attempting dry run of processing paper acceptance...
PDF failed to compile for issue #35 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 14 0 14 0 0 39 0 --:--:-- --:--:-- --:--:-- 39
pandoc-citeproc: reference sandvik not found
pandoc-citeproc: reference sandvik not found
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:44:in make_citation': undefined method
has_field?' for #block in generate_citations' from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in
each'
from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:29:in
generate_citations'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:214:in generate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:91:in
compile'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:76:in compile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in
run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in
dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:113:in
<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon accept
Attempting dry run of processing paper acceptance...
PDF failed to compile for issue #35 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 14 0 14 0 0 19 0 --:--:-- --:--:-- --:--:-- 19
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:44:in make_citation': undefined method
has_field?' for #block in generate_citations' from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in
each'
from /app/vendor/bundle/ruby/2.4.0/gems/bibtex-ruby-4.4.7/lib/bibtex/bibliography.rb:150:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/bibtex.rb:29:in
generate_citations'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:214:in generate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:91:in
compile'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:76:in compile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in
run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in
dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:113:in
<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
Hmm ... I think we ran into a funky bug. @arfon — What could be going on? @whedon accept
fails, but @whedon generate pdf
does compile the paper.
I think this is actually my issue. I use this bibtex on multiple multiple-author projects, and we include some string expansions for journals we cite from a bunch. I removed the translation block.
@whedon accept
Attempting dry run of processing paper acceptance...
PDF failed to compile for issue #35 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 14 0 14 0 0 46 0 --:--:-- --:--:-- --:--:-- 46
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:225:in ``': Argument list too long - cd tmp/35 && pandoc -V timestamp=20190116200213 -V doi_batch_id=858dbd49d7453083a43e92e3a1843090 -V formatted_doi=10.21105/jose.00035 -V archive_doi="https://doi.org/10.5281/zenodo.2541824" -V review_issue_url=https://github.com/openjournals/jose-reviews/issues/35 -V paper_url=http://www.theoj.org/openjournals/jose-papers/jose.00035/10.21105.jose.00035.pdf -V joss_resource_url=https://jose.theoj.org/papers/10.21105/jose.00035 -V journal_alias=jose -V journal_abbrev_title=JOSE -V journal_url=https://jose.theoj.org -V journal_name='Journal of Open Source Education' -V journal_issn=2577-3569 -V citations='
' -V authors='
' -V month=01 -V day=16 -V year=2019 -V issue=11 -V volume=2 -V page=35 -V title='treesiftr: An R package and server for viewing phylogenetic trees and data' -f markdown paper.md -o 10.21105.jose.00035.crossref.xml --template /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/resources/crossref.template
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:225:in generate_crossref' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/lib/whedon/processor.rb:91:in
compile'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:76:in compile' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in
run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in
dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-50d5912cf72a/bin/whedon:113:in
<top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
😱
That was surprising! Not even a little bit what I expected to occur.
I added back in the string expansion block. There were two of them. It's compiling on local via R's Knitr machinery.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
It compiles that way ... I notice that two references bleed out of the right margin (long DOIs). Can you think of any way to fix that? @arfon, we may still need your help here, sorry!
It's such an odd format for a DOI. I also see a render issue in the references on a hyphenated first name. I'll wait to push my fix until I hear back on this issue.
It compiles that way ... I notice that two references bleed out of the right margin (long DOIs). Can you think of any way to fix that? @arfon, we may still need your help here, sorry!
Lemme see what I can do. I think https://github.com/openjournals/whedon/pull/39 might fix this.
Unfortunately this is a non-trivial fix. I can fix one of the DOI strings but the longer one is going to require some work. @labarba - it's up to you how we proceed from here, i.e. we could wait to see if we can get this fixed or accept now and update the paper later when we have a fix.
@arfon — What if we publish it, wait for the fix, then fix the PDF and update the Crossref deposit? The downside is remembering to do this — I find it ugly to have a published paper with a broken layout.
@wrightaprilm Another option is for you to use the initial only for the second author and also abbreviate the journal title, in the hopes the DOI moves left enough.
Abbreviation from: http://images.webofknowledge.com/images/help/WOS/A_abrvjt.html AMERICAN BIOLOGY TEACHER AM BIOL TEACH
Let me play with it a bit tomorrow. If I clone Whedon, I can compile within template on my local, correct? That way I can goof around without bothering everyone?
Thanks for all your help - what a weird little hiccup!
Please note this issue I just opened: https://github.com/wrightaprilm/treesiftr/issues/5
@wrightaprilm — You can use the command @whedon generate pdf
here, yourself, to see how your changes affect the compiled paper.
OK, great. I see your issue, and I'm fixing it in a larger 'omnibus' of slightly broken bibtex issues. I have the next 53 minutes earmarked to revise an abstract, but I'll try out a few options for correcting the issue in the morning.
Thanks!
@arfon — What if we publish it, wait for the fix, then fix the PDF and update the Crossref deposit? The downside is remembering to do this — I find it ugly to have a published paper with a broken layout.
Yes, I think we should do this.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
All right, I zapped one of them. There's still a tiny bit of template breaking on the phylogeny.io citation, but I'm happy enough with it. I'd be fine to go ahead, then fix it later.
Feng & Doolittle (1987) has a DOI (not listed): https://doi.org/10.1007/BF02603120 (also, please capitalize the journal name)
Felsenstein (1973) does, too: https://doi.org/10.1093/sysbio/22.3.240
Felsenstein (1978) is https://doi.org/10.2307/2412810
Gower & Ross (1969) is http://doi.org/10.2307/2346439
... please go down the reference list and add any more missing DOIs.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Submitting author: @wrightaprilm (April Wright) Repository: https://github.com/wrightaprilm/treesiftr Version: v1.0.0 Editor: @juanklopper Reviewer: @ethanwhite, @rachelss Archive: 10.5281/zenodo.2541824
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ethanwhite & @rachelss, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://jose.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @juanklopper know.
Review checklist for @ethanwhite
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @rachelss
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?