Closed whedon closed 3 months ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @howardjp, @jwagemann it looks like you're currently assigned to review this paper :tada:.
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/jose-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿
To fix this do the following two things:
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1126/science.aad9837 is OK
- 10.3386/w25189 is OK
- 10.3386/w22181 is OK
- 10.1088/1748-9326/ab281e is OK
- 10.1002/wcc.579 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
👋 @jrising @howardjp @jwagemann the actual review for this submission will take place in this issue. Please note the review instructions and checklists at the top of the issue ☝️
@whedon generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
We have a new title 😄
We have a new title 😄
That's a good title.
Hi @kyleniemeyer It seems that I cannot trigger the checklist. Have I accepted the invitation to review? If I follow the link now, I get an error message.
Hi @jwagemann, how are you doing? 👋 I had the same problem when I was reviewing another submission, but I somehow solved it by making a change in the URL. I don't exactly remember what I changed 😄 but maybe this thread could help.
Hi @atrisovic . As far as I understand it this brings me to the error message. Maybe @kyleniemeyer can re-assign me? Thanks.
@whedon re-invite @jwagemann as reviewer
The reviewer already has a pending invite.
@jwagemann please accept the invite by clicking this link: https://github.com/openjournals/jose-reviews/invitations
@jwagemann please try that link ☝️
@kyleniemeyer - I get 'Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account.'
Before it was saying that the invite expired.
I think for me it worked when I viewed invitations from my profile, ie, something along the lines: https://github.com/<username>/<reponame>/invitations
🤔
It would be something like this in my case
https://github.com/jwagemann/openjournals/jose-reviews/invitations
? This brings me to a 404.
@openjournals/dev can you help here? not sure what is going on
@whedon re-invite @jwagemann as reviewer
I'm sorry @arfon, I'm afraid I can't do that. That's something only editors are allowed to do.
Can you try this URL again please @jwagemann: https://github.com/openjournals/jose-reviews/invitations
Great. Thanks @arfon . It works now.
I thank the authors for their time to develop the tutorial ‘ClimateEstimate.net - A tutorial on climate econometrics’ and giving me the opportunity to review it. The tutorial claims to be a ‘step-by-step guidance on carrying out a climatic econometric analysis’. My recommendation is to accept with major revisions
for the following reasons:
I opened a series of issues with recommendations / comments for each section in the tutorial:
I am happy to review a new submission.
Hi @jwagemann, thank you very much for your time, thorough review, and great comments! We will start working on this right away and follow up once we go through all the comments :)
Hi @jrising 👋 — do let us know how you are getting along with revising your submission! We are all digging out of the rubble of piled up work, and overall world chaos, so just give as a quick update when you can.
Thank you @labarba for the prompt! We have been going through the suggestions and thinking broadly about how to improve the structure of the tutorial in light of these comments. I have just replied to the full list of helpful comments. Here are responses to the points above from @jwagemann.
at the current state, it fails to meet the aim to be a step-by-step guide on how to carry out climatic econometrics. Sections often seem arbitrary and for a learner or external person it is often hard to understand what the section aims to describe or to do
We have made several improvements to address this. We added "learning objectives and decision points" boxes to the top of each main section of the tutorial. We added a consistent "hands-on exercise" to show how the various points can be put together. And we have made a number of improvements in the organization of sections, splitting up sections to make the key points clearer.
Many parts are not easy to follow, as authors try to capture too many aspects. Also many headlines seem a bit out of place, e.g the headline ‘Geographic Information Systems’ is used when the shapefile format is explained
This comment drove us to reconsider the structure of each section. In many cases,we have split up a large section (such as the one relating to GIS concepts) into multiple smaller sections. For example, we first introduce GIS concepts, then have a section on how to get shapefiles, and then a section on how to use them.
at the current state, the tutorial cannot be used by anyone other than the authors in order to teach students on the important topic of climatic econometrics
We have tried to make the tutorial much more accessible, and have shared it with more people. Crucially, we have also been more explicit about the background knowledge (mainly on econometrics) that we are expecting readers to have (in a section "Who is this tutorial for?"), while also including more references to other resources that will help readers get needed knowledge throughout the tutorial.
The smart use of images and explanatory media is missing. The tutorial is heavily based on text and hardly works with additional images that help to understand the complex content
While the tutorial is still quite "wordy", we have tried to make it more accessible in a few ways. First, we have made better use of Jupyter Book features like tabs (used now to split out different programming languages) and colored boxes (used to reference additional resources and highlight notes). We have also included a "Hands-On Exercise" that will allow readers to engage directly with the concepts in the tutorial. Finally, we have added more explanatory material to go with our images.
The general writing needs to be spell-checked and the general tone feels somehow a bit sloppy: e.g. ‘here are some suggestions for dealing with the mess that is political geography’ . I would not use the word ‘mess’ in any type of tutorial.
We apologize for these errors. We have done a more thorough editing process, and we have also passed the tutorial content through spell-checking and readability tools. We have also gotten comments back from other users, and adjusted the language to address their confusion.
The tutorial does not follow a consistent instructional design. Some sections are accompanied with code examples, others explain the content only in a very abstract way.
We hope that our inclusion of a common example will help make even the very general parts of the text more concrete. We have not used the same level of coding examples throughout the text, because of the wide range of challenges we hope that our tutorial can help students address: some challenges are conceptual, some informational, some mathematical, and some coding. We have worked to make the tutorial as a whole more consistent however.
Coding examples are either in R or try to show examples in multiple programming languages, which is quite confusing for the learner. I recommend to focus only on one programming language and provide only links to similar packages in other programming languages
It is quite common in this field to use multiple languages within a single project, and R, python, and Stata are all in common use amongst our audience. For this reason, we have kept the multiple languages, but we have improved how they are presented. In the previous version, they were included in the text in different ways. Now, we consistently use Jupyter Book tabs, to allow readers to quickly get the example in the language they need.
The tutorial misses an accompanying coding script in one of the programming languages. Without a coding script, it is very hard that a learner will be able to implement the content explained
We have now added this, in the form of a common hands-on exercise. The exercise is split into four steps, following the structure of the tutorial, and takes readers from downloading the necessary data through to getting out a dose-response function similar to the ones shown on the first page of the tutorial.
Hi @howardjp and @jwagemann, I just wanted to check if you've seen the updates in this submission. I'm looking forward to your thoughts! Of course, no pressure! Thanks! 😄
hi @howardjp, @jwagemann 👋 — It looks like the author of this JOSE submission made improvements and they are waiting for you to take a second look. Can you let us know when you might be able to do so? Thanks!
Hi @labarba 👋 , our reviewers don't seem to be active any more. Can we look for new reviewers? Maybe one of these people @/ali-ramadhan, @/marda-science, @/angela-li, @/leouieda can help? :)
Hi - it's on my list and I will get to it first week in November. Apologies for the delay - busy period.
Hi @jrising @atrisovic, sorry for the major delay here. I have checked in with the reviewers, and so far @jwagemann has confirmed being able to complete a second review in a few weeks.
@kyleniemeyer Thanks for the update.
@whedon generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Hi @kyleniemeyer , I finally had a chance to review the reviewed tutorial and I congratulate @jrising , @atrisovic and the other authors for producing this great resource. It is now well-structured and guides learners nicely through the content.
I recommend to accept. One small proposal of change: Under ERA5, instead of linking to UCAR’s ERA5 description, link to the description on the Climate Data Store: https://cds.climate.copernicus.eu/cdsapp#!/dataset/reanalysis-era5-single-levels?tab=overview
Hi @jwagemann and All, Thanks for the review! We have now incorporated the change! :)
@whedon generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Hi @kyleniemeyer, @labarba, what are the next steps for us? Do we need a second review at this stage (@howardjp)? Maybe someone else can step in if needed (ie, @/ali-ramadhan, @/marda-science, @/angela-li, @/leouieda). Thank you all!
Hi all, sorry for the (continued) delays here. @leouieda has agreed to serve as a second reviewer, and will take a look next week—but I do think this submission is in good shape.
@whedon add @leouieda as reviewer
OK, @leouieda is now a reviewer
@whedon remove @howardjp as reviewer
OK, @howardjp is no longer a reviewer
@kyleniemeyer Thanks for moving this forward!
@leouieda @kyleniemeyer Would it be possible to get an update on the review for this? At this point (as of some months ago), we completed the revision process for one reviewer, but we are still waiting on comments from another reviewer. It would be great to get this out!
@labarba @jgorzalski @kyleniemeyer (possibly @acocac @kls2177 ; my apologies, not sure who's responsible for this) Would it be possible to get an update on the review process for this? Thank you!
Hi @ks905383 @jrising unfortunately it looks like we lost a second reviewer. I will do a (non-expert) review myself and try to get this wrapped up soon.
@kyleniemeyer, I can provide a review (if needed). It is not directly in my area, but I may be able to help. I would probably need until the end of May to complete.
@kls2177 that would be great, thank you!
Submitting author: !--author-handle-->@jrising<!--end-author-handle-- (James Rising) Repository: https://github.com/atrisovic/weather-panel.github.io Branch with paper.md (empty if default branch): Version: v2.0 Editor: !--editor-->@kyleniemeyer<!--end-editor-- Reviewers: @jwagemann, @kls2177 Archive: 10.5281/zenodo.10833818
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jwagemann & @kls2177, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @jwagemann
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?Review checklist for @kls2177
Conflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
paper.md
file include a list of authors with their affiliations?