search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: STEDY - Software for TEnsegrity DYnamics #1000

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @vaishnavtv (Venkata Vaishnav Tadiparthi) Repository: https://github.com/uqLab/stedy Version: v0.1.0 Editor: @labarba Reviewers: @Kevin-Mattheus-Moerman, @ctdegroot

Author instructions

Thanks for submitting your paper to JOSS @vaishnavtv. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@vaishnavtv if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1000 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:83:in check_fields': Paper YAML header is missing expected fields: bibliography (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon.rb:69:ininitialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/lib/whedon/processor.rb:32:inset_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:inrun' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:indispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-dbdd2bfb2d31/bin/whedon:99:in<top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

vaishnavtv commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

vaishnavtv commented 5 years ago

@whedon list reviewers

whedon commented 5 years ago

Here's the current list of reviewers: https://bit.ly/joss-reviewers

vaishnavtv commented 5 years ago

In my submission, I suggested that @labarba be assigned as an editor, due to her experience with fluid dynamics. Was there a problem with that?

arfon commented 5 years ago

In my submission, I suggested that @labarba be assigned as an editor, due to her experience with fluid dynamics. Was there a problem with that?

No, that should be OK I think. @labarba - would you be able to handle this submission for JOSS?

labarba commented 5 years ago

I'm a little worried that this software lists as a dependency the Matlab Optimization Toolbox, which is an additional thousand bucks over Matlab. How am I going to find reviewers for such a thing?

vaishnavtv commented 5 years ago

In the list of JOSS reviwers, I found @moorepants who has listed multibody dynamics and optimal control as some of the domains that they are comfortable reviewing papers in, and also MATLAB in softwares they're proficient in. Would they be open to reviewing our paper? @ctdegroot is also listed as someone with experience in mechanical engineering and MATLAB.

ctdegroot commented 5 years ago

I have access to academic licenses for Matlab and the Optimization Toolbox. I would be able to do the review.

vaishnavtv commented 5 years ago

Perfect! Thank you!

moorepants commented 5 years ago

I'm sorry I do not have access to Matlab. If it runs in Octave I can review.

vaishnavtv commented 5 years ago

Would one reviewer be sufficient? @labarba

labarba commented 5 years ago

@whedon assign @labarba as editor

whedon commented 5 years ago

OK, the editor is @labarba

labarba commented 5 years ago

@ctdegroot : Are you still willing to be one of the reviewers for this submission? I will be looking for a second reviewer to help out.

labarba commented 5 years ago

@vaishnavtv : Your only reference in the paper is a manuscript that has been submitted but is not available without contacting the authors. Would you consider depositing your manuscript in a pre-print server? You can use arXiv, engrXiv, or other. A majority of journals accept preprints these days.

labarba commented 5 years ago

@Kevin-Mattheus-Moerman : Would you be able to review this submission for JOSS? It uses the Matlab Optimization Toolbox.

Kevin-Mattheus-Moerman commented 5 years ago

@labarba sure I can help. My expertise is solid mechanics and MATLAB but I'm new to (and interested in) tensegrity structures.

Kevin-Mattheus-Moerman commented 5 years ago

Perhaps folks at https://github.com/NASA-Tensegrity-Robotics-Toolkit e.g. @apsabelhaus (who contributed to https://github.com/apsabelhaus/tInvKin) would be interested in reviewing this?

Kevin-Mattheus-Moerman commented 5 years ago

My colleague at MIT might be interested in this too. @cybanical fancy testing some code to study dynamics of tensegrity structures? (also I recommend that you upgrade your github profile with an ORCID link, your real name, and some affiliation information etc).

labarba commented 5 years ago

@whedon assign @Kevin-Mattheus-Moerman as reviewer

labarba commented 5 years ago

Thank you, @Kevin-Mattheus-Moerman ! Let's wait and see if one of the folks you recommend can volunteer the second review, and then we can get it started.

ctdegroot commented 5 years ago

@labarba Yes, I am still able to review it

labarba commented 5 years ago

@whedon add @ctdegroot as reviewer

labarba commented 5 years ago

@arfon : Can you tell why our dear bot @whedon is ignoring my commands?

whedon commented 5 years ago

OK, the reviewer is @Kevin-Mattheus-Moerman

whedon commented 5 years ago

OK, @ctdegroot is now a reviewer

labarba commented 5 years ago

So ... I guess @whedon was sleeping. Now we're set!

labarba commented 5 years ago

@whedon start review

apsabelhaus commented 5 years ago

Dear all - very nice to meet you!

I'm happy to be a reviewer, though I'm not sure what this entails, I'm new to JOSS. I have the MATLAB Optimization Toolbox.

On a different note, the field of dynamics derivations for tensegrity structures is actually very extensive, and it would be very good to include many other knowledgeable experts in the area. There are well-known expressions for the dynamics of these structures that could be verified against the authors' code. In fact, the authors have a colleague at Texas A&M who is a forerunner in the area - Robert Skelton - who can refer good reviewers for this code. Other significant authors in the field include Cornel Sultan, Josep Mirats-Tur, and their students.

Of particular note would be other contributors to NTRTsim (https://github.com/NASA-Tensegrity-Robotics-Toolkit) such as Brian Mirletz @brtietz and the current maintainer Jonathan Bruce @JEB12345. Also, Jeffrey Friesen at @Jfriesen222 has already derived the dynamics for a large set of tensegrity robots.

Please let me know how you might like from me.

apsabelhaus commented 5 years ago

Another good reviewer would be Mauricio de Oliviera at UC San Diego.

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1042. Feel free to close this issue now!

Kevin-Mattheus-Moerman commented 5 years ago

@apsabelhaus thanks for those suggestions!

cybanical commented 5 years ago

@Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman This looks super interesting, but it looks like I'm too slammed right now. I've got two other papers to review right now for ICRA. _____ *MATTHEW CARNEY | Research Assistant and PhD Candidate *| Mechatronics Design Engineer MIT Media Lab | Biomechatronics 75 Amherst St. | E14-274G | Cambridge, MA 02142 USA biomech.media.mit.edu https://www.media.mit.edu/groups/biomechatronics/overview/ | matthematic.com | IG:@matt.thematic https://www.instagram.com/matt.thematic/

On Tue, Oct 23, 2018 at 3:45 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@apsabelhaus https://github.com/apsabelhaus thanks for those suggestions!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1000#issuecomment-432133377, or mute the thread https://github.com/notifications/unsubscribe-auth/ADa-d6wQM9p3_udKs4qKClgDT4siY6ngks5unskYgaJpZM4XLVB3 .

addyhsu commented 5 years ago

@labarba The software has been archived on Zenodo. DOI: 10.5281/zenodo.2527084

labarba commented 5 years ago

@whedon set 10.5281/zenodo.2527084 as archive

whedon commented 5 years ago

OK. 10.5281/zenodo.2527084 is the archive.

labarba commented 5 years ago

Wrong issue. We should be at https://github.com/openjournals/joss-reviews/issues/1042