search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: EMViz (Early Music Visualization): MATLAB runtime application #1094

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @carterenyi (Aaron Carter-Enyi) Repository: https://github.com/carterenyi/emviz Version: v1.0.1 Editor: @Kevin-Mattheus-Moerman Reviewers: @ybayle Archive: 10.5281/zenodo.3051781

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/a9752eb882eefa9e3ec06e3c4aa6a50d"><img src="http://joss.theoj.org/papers/a9752eb882eefa9e3ec06e3c4aa6a50d/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/a9752eb882eefa9e3ec06e3c4aa6a50d/status.svg)](http://joss.theoj.org/papers/a9752eb882eefa9e3ec06e3c4aa6a50d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ybayle, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @ybayle

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @ybayle, it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 5 years ago

@ybayle, @gwynethbradbury, thanks for agreeing to review this submission for JOSS! :tada: This is where the review process takes place. There are instructions and check boxes at the top of this issue that guide you through the process. Feel free to open issues you have on the project repository, and please refer to them here as well e.g. by making a checkbox list (using - [ ]):

Minor comment

  • [ ] I have this minor issue [LINK TO ISSUE 1]

Major issues:

  • [ ] and this one [LINK TO ISSUE 2]

Let me know if you have any questions.

ybayle commented 5 years ago

[First part of the review]

- Version: Does the release version given match the GitHub release (v1.0.0)?

There is no release currently (cf https://github.com/carterenyi/emviz/releases). Would it be possible to have a released version or is it preferable to wait for the end of the review process?

- Authorship: Does the full list of paper authors seem appropriate and complete?

There is no clear context about the work done. There are no references to William S. Dula that is mentioned on the pdf on the windows download link nor to Khalif Ali that is mentioned as the proprietary of the repository where the installer and pdf are stored. Would it be possible to have more details about them as they are not mentioned in the list of authors?

- Installation instructions.

The installation procedure works fine on Windows 7. I haven't tested it yet on Mac nor Windows 10 but I will soon. For a direct git clone, there was a missing Matlab addpath that seems to have been resolved with the latest commit https://github.com/carterenyi/emviz/commit/74a60b6d49042d4cf0618d97599a7f70ba78c52d I have to retry from scratch the install process to double check this. Yet, there is still a problem with the program when cloned and launch from scratch. The GUI can handle the loading of a MIDI file and plot correctly but after the first plot, there are multiple error messages and no buttons react at all. This is a behaviour that I did not observe with the windows installer. Do you have the same problem on your side? Could you provide a detailed procedure to launch the GUI from a git clone in a Matlab environment?

carterenyi commented 5 years ago

Response to @ybayle https://github.com/ybayle:

First of all, thank you!

Version: I will work on that, if @Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman has any insight on the standard for JOSS, it would be appreciated Authorship: I am the sole author of the MATLAB code. Mr. Dula and Mr. Ali were undergrad students hired to translate the existing MATLAB code into Python. Mr. Ali dropped from the project without completing any translations, Mr. Dula is still working with me on the Python translation and when that is released will be credited as a coauthor. Installation instructions: Deploying the functions as a MATLAB Runtime application for Mac with MATLAB Compiler SDK has been a consistent issue and that version (which was the best after many tries) only works on about 50% of Mac systems. I have contacted Mathworks repeatedly but they don't have great support for Mac, their only suggestion was to zip the application. Perhaps this should be a Windows only release. Mac users that have MATLAB can run it in MATLAB without having to use the MATLAB Runtime version.

@Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman what's the next step?

Aaron

On Sun, Dec 2, 2018 at 2:34 PM Yann Bayle notifications@github.com wrote:

[First part of the review]

  • Version: Does the release version given match the GitHub release (v1.0.0)?

There is no release currently (cf https://github.com/carterenyi/emviz/releases). Would it be possible to have a released version or is it preferable to wait for the end of the review process?

  • Authorship: Does the full list of paper authors seem appropriate and complete?

There is no clear context about the work done. There are no references to William S. Dula that is mentioned on the pdf on the windows download link nor to Khalif Ali that is mentioned as the proprietary of the repository where the installer and pdf are stored. Would it be possible to have more details about them as they are not mentioned in the list of authors?

  • Installation instructions.

The installation procedure works fine on Windows 7. I haven't tested it yet on Mac nor Windows 10 but I will soon. For a direct git clone, there was a missing Matlab addpath that seems to have been resolved with the latest commit carterenyi/emviz@74a60b6 https://github.com/carterenyi/emviz/commit/74a60b6d49042d4cf0618d97599a7f70ba78c52d I have to retry from scratch the install process to double check this. Yet, there is still a problem with the program when cloned and launch from scratch. The GUI can handle the loading of a MIDI file and plot correctly but after the first plot, there are multiple error messages and no buttons react at all. This is a behaviour that I did not observe with the windows installer. Do you have the same problem on your side? Could you provide a detailed procedure to launch the GUI from a git clone in a Matlab environment?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-443535240, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6qOHxM6VudvZ_sXlT-Ju8LD8jrdJks5u1CtUgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

Kevin-Mattheus-Moerman commented 5 years ago

@gwynethbradbury thanks again for helping with this review. When can we expect your review contribution?

Kevin-Mattheus-Moerman commented 5 years ago

@carterenyi about the version issue. Yes you can create a release and let us know about the version number after the review process is complete. Rebranding this as a Windows only release sounds like a good plan for now. Perhaps make changes to the readme/documentation to reflect this. Are you able to continue the review process on a Windows system? Thanks. @ybayle thanks for your review efforts so far! Would you be able to focus on evaluation for Windows? Thanks.

ybayle commented 5 years ago

@Kevin-Mattheus-Moerman I will focus on the Windows releases.

References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Could you clarify, which check do you expect from that question?

@carterenyi Thank you for the details you provided.

Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?

There are no minimial test suite to check for regression or functionnality. Do you think you could do that?

Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?

There are no documentation. However, you already have documented some functions and some files in your project. Do you think you could refactor your comments and use a documentation generator (e.g. Sphinx, Doxygen, ...)?

Functionality: Have the functional claims of the software been confirmed?

screenshot

The GUI seems broken in Windows 7 and does not looks like the Mac version displayed in https://github.com/carterenyi/emviz/blob/master/EMViz_Manual.pdf. So far the program seems to work correctly even with this GUI's text misplacements.

Kevin-Mattheus-Moerman commented 5 years ago

@ybayle thanks for these comments.

In relation to DOI's I've opened an issue on this (https://github.com/carterenyi/emviz/issues/4) whenever DOI's are available they need to be added. @carterenyi can you work on adding those?

carterenyi commented 5 years ago

@Kevin-Mattheus-Moerman Yes, I will work on adding the DOIs

On Wed, Dec 19, 2018 at 5:30 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@ybayle https://github.com/ybayle thanks for these comments.

In relation to DOI's I've opened an issue on this (carterenyi/emviz#4 https://github.com/carterenyi/emviz/issues/4) whenever DOI's are available they need to be added. @carterenyi https://github.com/carterenyi can you work on adding those?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-448546538, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6paJXfNn8ERYH_KbspULIhmcXNY5ks5u6hU4gaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

Kevin-Mattheus-Moerman commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 5 years ago

Happy 2019 everybody.

@carterenyi how are you getting on? Did you manage to check those DOI's in the paper?

@ybayle, @gwynethbradbury can you provide an update on the review process? What are the major issues @carterenyi should work on? Thanks.

ybayle commented 5 years ago

Happy 2019 everybody.

Thank you and best wishes to you too.

@ybayle can you provide an update on the review process?

There are still comments to be processed by the author from here: https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-448377467

What are the major issues @carterenyi should work on? Thanks.

The GUI does not display properly on Windows and the Github cloned version only works once.

carterenyi commented 5 years ago

Hello All,

Thanks for checking in. I am in Nigeria without a strong internet connection so it is not easy for me to work on the article right now. I hope to complete the DOIs, GUI display and cloning issues by the end of the month.

Aaron

On Fri, Jan 4, 2019 at 1:49 PM Yann Bayle notifications@github.com wrote:

Happy 2019 everybody.

Thank you and best wishes to you too.

@ybayle https://github.com/ybayle can you provide an update on the review process?

There are still comments to be processed by the author from here: #1094 (comment) https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-448377467

What are the major issues @carterenyi https://github.com/carterenyi should work on? Thanks.

The GUI does not display properly on Windows and the Github cloned version only works once.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-451435268, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6gaEfh8fDXfQtQp9JwpFfGJGGDxJks5u_03QgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

Kevin-Mattheus-Moerman commented 5 years ago

@carterenyi how are you getting on? Have you been able to resume work on this?

carterenyi commented 5 years ago

Hi Kevin,

Thanks so much for following up. Just got back to US and resumed teaching, hope to complete the revisions by next week.

Aaron

On Thu, Jan 31, 2019 at 9:15 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@carterenyi https://github.com/carterenyi how are you getting on? Have you been able to resume work on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-459359325, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6hVPy9OImbgpo46KHIwpR340SVYEks5vIvqZgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

Kevin-Mattheus-Moerman commented 5 years ago

@carterenyi Thanks, looking forward to seeing your comments.

Kevin-Mattheus-Moerman commented 5 years ago

@carterenyi any updates on the review process? Thanks!

carterenyi commented 5 years ago

Hi Kevin,

I've updated my matlab to 2018b on my mac and am now working on the revisions. I've ordered a pc so that I can deploy the windows version. I hope to have an update within a week.

On Sun, Feb 10, 2019 at 3:35 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@carterenyi https://github.com/carterenyi any updates on the review process? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-462114035, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6gwCZUYL8Kd3yGcqCTap3eQvA9U0ks5vL9nfgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

carterenyi commented 5 years ago

@Kevin-Mattheus-Moerman DOIs, urls and/or ISBNs have been added to all references where applicable. The windows laptop I ordered arrived yesterday so I should be able to fix the GUI display issue for Windows 10 this week.

On Thu, Feb 21, 2019 at 2:41 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

Hi Kevin,

I've updated my matlab to 2018b on my mac and am now working on the revisions. I've ordered a pc so that I can deploy the windows version. I hope to have an update within a week.

On Sun, Feb 10, 2019 at 3:35 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@carterenyi https://github.com/carterenyi any updates on the review process? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-462114035, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6gwCZUYL8Kd3yGcqCTap3eQvA9U0ks5vL9nfgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

carterenyi commented 5 years ago

@whedon https://github.com/whedon generate pdf

On Sun, Feb 24, 2019 at 7:47 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

@Kevin-Mattheus-Moerman DOIs, urls and/or ISBNs have been added to all references where applicable. The windows laptop I ordered arrived yesterday so I should be able to fix the GUI display issue for Windows 10 this week.

On Thu, Feb 21, 2019 at 2:41 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

Hi Kevin,

I've updated my matlab to 2018b on my mac and am now working on the revisions. I've ordered a pc so that I can deploy the windows version. I hope to have an update within a week.

On Sun, Feb 10, 2019 at 3:35 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@carterenyi https://github.com/carterenyi any updates on the review process? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-462114035, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6gwCZUYL8Kd3yGcqCTap3eQvA9U0ks5vL9nfgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

carterenyi commented 5 years ago

@whedon https://github.com/whedon generate pdf

On Tue, Feb 26, 2019 at 12:49 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

@whedon https://github.com/whedon generate pdf

On Sun, Feb 24, 2019 at 7:47 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

@Kevin-Mattheus-Moerman DOIs, urls and/or ISBNs have been added to all references where applicable. The windows laptop I ordered arrived yesterday so I should be able to fix the GUI display issue for Windows 10 this week.

On Thu, Feb 21, 2019 at 2:41 PM Aaron Carter-Enyi carterenyi@gmail.com wrote:

Hi Kevin,

I've updated my matlab to 2018b on my mac and am now working on the revisions. I've ordered a pc so that I can deploy the windows version. I hope to have an update within a week.

On Sun, Feb 10, 2019 at 3:35 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@carterenyi https://github.com/carterenyi any updates on the review process? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-462114035, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6gwCZUYL8Kd3yGcqCTap3eQvA9U0ks5vL9nfgaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

-- Aaron Carter-Ényì, PhD, CAGO

carterenyi commented 5 years ago

@whedon commands

whedon commented 5 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references
carterenyi commented 5 years ago

@whedon check references

whedon commented 5 years ago 
Attempting to check references...
carterenyi commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1094 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 15 0 15 0 0 248 0 --:--:-- --:--:-- --:--:-- 250 Error reading bibliography ./paper.bib (line 66, column 4): unexpected "t" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

whedon commented 5 years ago 

OK DOIs

- http://doi.org/doi.org/10.30535/mto.22.1.1 is OK
- http://doi.org/10.2307/745755 is OK
- http://doi.org/10.1121/1.387814 is OK

MISSING DOIs

- None

INVALID DOIs

- None
carterenyi commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

carterenyi commented 5 years ago

@whedon check references

whedon commented 5 years ago 
Attempting to check references...
whedon commented 5 years ago 

OK DOIs

- http://doi.org/10.30535/mto.22.1.1 is OK
- http://doi.org/10.2307/745755 is OK
- http://doi.org/10.1121/1.387814 is OK

MISSING DOIs

- None

INVALID DOIs

- None
carterenyi commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1094 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/author.rb:58:in block in build_affiliation_string': Problem with affiliations for Aaron Carter-Ényì, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/author.rb:57:ineach' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/author.rb:57:in build_affiliation_string' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/author.rb:17:ininitialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:109:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:109:inblock in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:106:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:106:inparse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:73:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/processor.rb:32:innew' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:55:inprepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

carterenyi commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

carterenyi commented 5 years ago

@Kevin-Mattheus-Moerman, @ybayle, I've redeployed the software with MATLAB 2018b on Windows 10 and tested it. I've also added functionality testing instructions in the readme, generated documentation with m2html and updated information about windows only release in the paper and pdf. I did a v1.0 release on GitHub, but not sure if I did that right.

Kevin-Mattheus-Moerman commented 5 years ago

@ybayle, @gwynethbradbury are you able to pick up the review process.

@ybayle are you a happy with the revisions proposed by @carterenyi?

Kevin-Mattheus-Moerman commented 5 years ago

@ybayle, @gwynethbradbury :wave: :point_up:

ybayle commented 5 years ago

The revised version works fine for me. As the computation process may take some time, it would be nice to have a little text message indicating to wait (or better to have a progress bar). Currently, I don't know if the program has crashed or is running.

Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified? This is the last check remaining. There are no automated tests implemented currently for the 3 parts of the algo (namely Data Preparation, Pattern Recognition and Visualization). How critical is this assertion for the review process?

Minor typos in the pdf:

carterenyi commented 5 years ago

@Kevin-Mattheus-Moerman, @ybayle,

Manual steps are provided to verify functionality of the Pattern Recognition and Visualization (with the csv output and arc diagram), neither of which will be correct without the data preparation working. Is that satisfactory?

I'll fix the minor typos.

On Wed, Mar 20, 2019 at 3:23 PM Yann Bayle notifications@github.com wrote:

The revised version works fine for me.

Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified? This is the last check remaining. There are no automated tests implemented currently for the 3 parts of the algo (namely Data Preparation, Pattern Recognition and Visualization). How critical is this assertion for the review process?

Minor typos in the pdf:

  • There are extra parenthesis for some citations (e.g. ([@Wattenberg:2002]) instead of [@Wattenberg:2002])
  • currently being developing Python

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1094#issuecomment-474992274, or mute the thread https://github.com/notifications/unsubscribe-auth/AXim6kMCUD7YES_4V_WGv2DvyWJx6SgOks5vYoqggaJpZM4YtePz .

-- Aaron Carter-Ényì, PhD, CAGO