openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: LightTwinSVM: A Simple and Fast Implementation of Standard Twin Support Vector Machine Classifier #1155

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @mir-am (A. Mir) Repository: https://github.com/mir-am/LightTwinSVM Version: v0.5.0 Editor: @cMadan Reviewers: @stefanv

Author instructions

Thanks for submitting your paper to JOSS @mir-am. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@mir-am if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

mir-am commented 5 years ago

Hello First, we are very grateful for the consideration of our paper. Before starting the review process, we need to make some minor revisions to our paper to solve problems like an undefined reference. However, we need an editor to be assigned. (We have suggested @arfon, Mr. Smith)

Regards, Mir

arfon commented 5 years ago

:wave: @mir-am - thanks for your submission to JOSS. Please go ahead and make the changes you need to for your paper and ask @whedon to recompile your paper here with the command whedon generate pdf.

However, we need an editor to be assigned. (We have suggested @arfon, Mr. Smith)

I probably won't edit this submission - it may take another few days for an editor to be assigned.

mir-am commented 5 years ago

@arfon - Thanks for replying. We carefully revised our paper and would like to assign an editor for consideration of the paper

mir-am commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

cMadan commented 5 years ago

@whedon assign @cmadan as editor

cMadan commented 5 years ago

@mir-am, thank you for your submission. Do you have any suggestions for reviewers? (See first comment in this issue for more information.)

cMadan commented 5 years ago

@arfon, it seems that whedon updated the first comment with me as editor, but didn't 'acknowledge' the command or assign me to the issue in Github. Has anything changed with how it's supposed to do that...?

mir-am commented 5 years ago

@whedon assign @cMadan as editor

We thank you for the consideration of our paper. @cMadan - @arfon - How can we add a caption to a table in our paper?

mir-am commented 5 years ago

@mir-am, thank you for your submission. Do you have any suggestions for reviewers? (See first comment in this issue for more information.)

We suggest @glemaitre for reviewing our research work.

cMadan commented 5 years ago

@mir-am, this should do it: https://pandoc.org/MANUAL.html#tables

mir-am commented 5 years ago

@mir-am, this should do it: https://pandoc.org/MANUAL.html#tables

Thanks. We revised our paper. We would like to start the review process.

mir-am commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

cMadan commented 5 years ago

@whedon assign @cMadan as editor

whedon commented 5 years ago

OK, the editor is @cMadan

cMadan commented 5 years ago

@arfon, not sure what happened earlier, but didn't seem like @whedon acted properly earlier. This time it worked though.

arfon commented 5 years ago

@arfon, not sure what happened earlier, but didn't seem like @whedon acted properly earlier. This time it worked though.

Weird. Not sure. Seems like a minor hiccup...

cMadan commented 5 years ago

@glemaitre, would you be interested and available to review this submission? Thank you for your consideration!

glemaitre commented 5 years ago

@cMadan I'm sorry but I will not be able to review right now. I am lacking personal time to make the review and I don't want to be the latent factor.

mir-am commented 5 years ago

Hi We would like to suggest @rougier for reviewing our research work. We also welcome reviewer suggestions from the editor.

cMadan commented 5 years ago

@mir-am, I am asking around for additional reviewers and hopefully someone will volunteer.

I was looking at the figures in the paper, are the SVM and TwinSVM illustrations based on the same data?

mir-am commented 5 years ago

@mir-am, I am asking around for additional reviewers and hopefully someone will volunteer.

I was looking at the figures in the paper, are the SVM and TwinSVM illustrations based on the same data?

Thanks. The dataset for both illustrations is nearly the same. Data points are randomly selected from an artificial dataset. However, we can change the two illustrations by training both classifiers on the exact same dataset.

rougier commented 5 years ago

I can review but it'll take me some time (3/4 weeks) because I'm a bit busy right now.

cMadan commented 5 years ago

@mir-am, I think it would be better if they are the exact same, thanks!

@rougier, that sounds fine to me. I won't start the review yet in case someone else is also able/interested to review, but if you could comment here when your free, I'll start the review even if no one else has volunteered.

mir-am commented 5 years ago

@cMadan We revised the paper and added new illustrations of SVM and TwinSVM based on the exact same dataset.

mir-am commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1155 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 15 0 15 0 0 234 0 --:--:-- --:--:-- --:--:-- 238 Error producing PDF. ! Undefined control sequence. \SQSPL@scan ->\futurelet \SQSPL@next \SQSPL@scani l.388 \texttt{Scikit-learn}'s SVM\label{tab:1}}

Looks like we failed to compile the PDF

mir-am commented 5 years ago

PDF failed to compile for issue #1155 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 15 0 15 0 0 234 0 --:--:-- --:--:-- --:--:-- 238 Error producing PDF. ! Undefined control sequence. \SQSPL@scan ->\futurelet \SQSPL@next \SQSPL@scani l.388 \texttt{Scikit-learn}'s SVM\label{tab:1}}

Looks like we failed to compile the PDF

@arfon @cMadan The paper successfully compiled on my machine using Pandoc. However, whedon cannot compile the paper and produced above error.

arfon commented 5 years ago

Looks like this is a bug with our recently updated LaTeX template. I'll work on fixing this shortly.

arfon commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

mir-am commented 5 years ago

@arfon Thanks for fixing the error.

We would like to start the review process if possible.

arfon commented 5 years ago

We would like to start the review process if possible.

@mir-am - @cMadan is still looking for reviewers here I think.

cMadan commented 5 years ago

@mir-am, yes, I still need to find someone to review the submission.

cMadan commented 5 years ago

@raamana, would you be interested and available to review this submission?

@arokem, do you have any suggestions for others who may be suitable reviewers here?

raamana commented 5 years ago

Thanks Chris, happy to review, this is an interesting and useful tool. However, due to prior commitments etc, I may take 4-8 weeks.

cMadan commented 5 years ago

@raamana, thanks! I'll see if @arokem has any suggestions, otherwise will ping you here in a few weeks and see when you're ready to start.

raamana commented 5 years ago

Sounds good. I'm unsubscribing for now. Please mention me so I get pinged.

labarba commented 5 years ago

👋 @rougier In your comment here 28 days ago you said you might be able to review this submission for JOSS? It's still waiting for reviewer assignment. Can you help us?

labarba commented 5 years ago

I wonder if @stefanv could help here ... Stefan: are you able to review this submission for JOSS?

stefanv commented 5 years ago

I'd be happy to!

labarba commented 5 years ago

@whedon assign @stefanv as reviewer