openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: QMix: A Python package for simulating the quasiparticle tunneling currents in SIS junctions #1175

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @garrettj403 (John Garrett) Repository: https://github.com/garrettj403/QMix/ Version: v1.0.0 Editor: @labarba Reviewers: @FaustinCarter, @josephhardinee, @PaulKGrimes

Author instructions

Thanks for submitting your paper to JOSS @garrettj403. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@garrettj403 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @labarba it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@labarba) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
arfon commented 5 years ago

:wave: @labarba - the submitting author suggested you as the handling editor.

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

garrettj403 commented 5 years ago

Hello @labarba, I took a look at the list of potential reviewers and I would recommend FaustinCarter because he is familiar with superconductors and instrumentation for astrophysics.

If he is unavailable, kpeeters, cr458 and ivergara could be other options.

Thank you!

labarba commented 5 years ago

@whedon check references

whedon commented 5 years ago
Attempting to check references...
whedon commented 5 years ago

OK DOIs

- http://doi.org/10.1109/JQE.1979.1069931 is OK
- http://doi.org/10.1103/RevModPhys.57.1055 is OK
- http://doi.org/10.1063/1.1576515 is OK
- http://doi.org/10.1063/1.2424407 is OK
- http://doi.org/10.5281/zenodo.2538163 is OK
- http://doi.org/10.1103/PhysRev.147.255 is OK

MISSING DOIs

- None

INVALID DOIs

- None
labarba commented 5 years ago

This submission is pretty far outside of my domains of even fuzzy understanding, but I'm going to try some gut-feeling pings to some registered JOSS reviewers. Maybe signal processing? —Could this be something you can review for JOSS, @josephhardinee?

labarba commented 5 years ago

Perhaps a physicist like @FaustinCarter could help out with this review? (Going by "detector physics" on his JOSS reviewer listing.)

FaustinCarter commented 5 years ago

I'm happy to review this. I'm a little back-logged with work this week, so won't be able to start until next week. Is that cool with everyone?

labarba commented 5 years ago

@whedon assign @FaustinCarter as reviewer

whedon commented 5 years ago

OK, the reviewer is @FaustinCarter

labarba commented 5 years ago

Just pinged @josephhardinee by email to see if he can be our second reviewer. Stay tuned.

josephhardinee commented 5 years ago

Sure. It is pretty far outside of my area of expertise, but if @FaustinCarter can handle domain specific I can help look at some of the more general portions.

On Mon, Jan 28, 2019 at 3:09 PM Lorena A. Barba notifications@github.com wrote:

Just pinged @josephhardinee https://github.com/josephhardinee by email to see if he can be our second reviewer. Stay tuned.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1175#issuecomment-458282327, or mute the thread https://github.com/notifications/unsubscribe-auth/AAufaLlDszRO6EJf5B_JHvXezXG7EQ3sks5vH1jegaJpZM4aAwUj .

-- Joseph Hardin, Ph.D. Pacific Northwest National Laboratory ARM Radar Engineering and Operations

One must do not violence to nature, nor model it in conformity to any blindly formed chimaera. -Janos Boylai

labarba commented 5 years ago

Thanks, @josephhardinee 🙏

@whedon add @josephhardinee as reviewer

labarba commented 5 years ago

@whedon add @josephhardinee as reviewer

whedon commented 5 years ago

OK, @josephhardinee is now a reviewer

labarba commented 5 years ago

👋 @garrettj403 — I'm pretty stretched with this editing assignment, and one of the reviewers volunteered to look at general software checks but also has no expertise in the domain. Would you like to suggest a reviewer knowledgeable of your domain of application?

garrettj403 commented 5 years ago

Thank you @josephhardinee and @FaustinCarter for agreeing to review QMix!

@labarba, I've sent a few emails around to try to find a third reviewer. I'll let you know as soon as I hear back.

garrettj403 commented 5 years ago

Hi @labarba, I emailed @paulkgrimes and he's able to be a reviewer. He has worked on SIS mixers for +10 years, so he is able to review the components that require in-depth knowledge of SIS mixers.

labarba commented 5 years ago

👋 @PaulKGrimes — We hear you are willing to provide a review for this submission to JOSS? (Please confirm.) We have two other reviewers, but since the subject of the paper is far out of my areas of expertise, I would welcome another pair of eyes on this.

PaulKGrimes commented 5 years ago

Hi Lorena,

Yes, I'm absolutely willing to review this submission. I've been working on SIS mixer simulation on and off in Python and C++ for the past 16 years, so hopefully I can provide useful feedback.

Paul Grimes -- Submillimeter Array/Receiver Laboratory Center for Astrophysics | Harvard & Smithsonian +1 (617) 496-7640

On Mon, Feb 4, 2019 at 2:12 PM Lorena A. Barba notifications@github.com wrote:

👋 @PaulKGrimes https://github.com/PaulKGrimes — We hear you are willing to provide a review for this submission to JOSS? (Please confirm.) We have two other reviewers, but since the subject of the paper is far out of my areas of expertise, I would welcome another pair of eyes on this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1175#issuecomment-460373322, or mute the thread https://github.com/notifications/unsubscribe-auth/AafsyXL9pHtcWzZSFMckcxucOpJc9D5fks5vKIYVgaJpZM4aAwUj .

-- Receiver Laboratory Smithsonian Astrophysical Observatory 60 Garden St, Cambridge, MA 02138 +1 (617) 496-7640

labarba commented 5 years ago

@whedon add @PaulKGrimes as reviewer

whedon commented 5 years ago

OK, @PaulKGrimes is now a reviewer

labarba commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1231. Feel free to close this issue now!