[REVIEW]: NeuroDSP: A package for neural digital signal processing

whedon commented 5 years ago

Submitting author: @voytek (Bradley Voytek) Repository: https://github.com/neurodsp-tools/neurodsp Version: 2.0.0 Editor: @arokem Reviewer: @TomDLT Archive: 10.5281/zenodo.2643784

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/5bb4c745b842289dd5b1b8832ddb443d"><img src="http://joss.theoj.org/papers/5bb4c745b842289dd5b1b8832ddb443d/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/5bb4c745b842289dd5b1b8832ddb443d/status.svg)](http://joss.theoj.org/papers/5bb4c745b842289dd5b1b8832ddb443d)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@TomDLT, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @TomDLT

Conflict of interest

[x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Version: 2.0.0
[x] Authorship: Has the submitting author (@voytek) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Authors: Does the paper.md file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

whedon commented 5 years ago

Attempting PDF compilation. Reticulating splines etc...

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

TomDonoghue commented 5 years ago

Okay, two small fixes / updates:

Fixed the references for when there are multiple refs for the same claim, so it doesn't add extra parentheses to the year.
Added links to the ByCycle & FOOOF toolboxes.

Otherwise - I did another check through, and everything looks good to me now! Can confirm to go through to the acceptance process! Thanks @arokem

arokem commented 5 years ago

👋 @openjournals/joss-eics : I believe this paper is ready to be accepted. Could you please take a look?

arfon commented 5 years ago

@whedon accept

whedon commented 5 years ago

Attempting dry run of processing paper acceptance...

whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/629

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/629, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

whedon commented 5 years ago


OK DOIs

- 10.1126/science.1099745 is OK
- 10.1038/nrn3241 is OK
- 10.1101/452987 is OK
- 10.1101/302000 is OK
- 10.1073/pnas.1517629112 is OK
- 10.1016/j.neuroimage.2015.06.003 is OK
- 10.1007/s11571-008-9064-y is OK
- 10.1016/j.neuroimage.2017.06.078 is OK
- 10.1016/j.jneumeth.2016.11.001 is OK
- 10.1016/j.neuroimage.2013.10.027 is OK
- 10.1101/299859 is OK
- 10.1016/j.tics.2014.04.003 is OK
- 10.1371/journal.pcbi.1000609 is OK
- 10.1523/JNEUROSCI.2332-14.2015 is OK

MISSING DOIs

- None

INVALID DOIs

- None

arfon commented 5 years ago

@whedon accept deposit=true

whedon commented 5 years ago

Doing it live! Attempting automated processing of paper acceptance...

whedon commented 5 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/630
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01272
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

arfon commented 5 years ago

@TomDLT - many thanks for your review here and to @arokem for editing this submission :sparkles:

@voytek - your paper is now accepted into JOSS :zap::rocket::boom:

whedon commented 5 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01272/status.svg)](https://doi.org/10.21105/joss.01272)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01272">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01272/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01272/status.svg
   :target: https://doi.org/10.21105/joss.01272

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.salsalabs.org/donate-to-joss

openjournals / joss-reviews