[REVIEW]: The Climate Equity Reference Calculator

whedon commented 5 years ago

Submitting author: !--author-handle-->@krueschan@jedbrown@mtobis<!--end-reviewers-list-- Archive: 10.5281/zenodo.2592644

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/3a39361da648816fccf17af893b2b440"><img src="http://joss.theoj.org/papers/3a39361da648816fccf17af893b2b440/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/3a39361da648816fccf17af893b2b440/status.svg)](http://joss.theoj.org/papers/3a39361da648816fccf17af893b2b440)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mtobis, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @jedbrown know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @mtobis

Conflict of interest

[x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Version: v3.2.2
[x] Authorship: Has the submitting author (@krueschan) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Authors: Does the paper.md file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

krueschan commented 5 years ago

Ok, good points, thanks. I fixed it, though using a different approach than you suggested, by joining putting parts of the sentence into the parenthesis with the citations. Also, the comma after e.g.

krueschan commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago

Attempting PDF compilation. Reticulating splines etc...

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

labarba commented 5 years ago

@whedon accept

whedon commented 5 years ago

Attempting dry run of processing paper acceptance...

whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/556

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/556, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

whedon commented 5 years ago


OK DOIs

- 10.1007/s10784-017-9371-z is OK
- 10.1002/wcc.201 is OK
- 10.5281/zenodo.1748847 is OK
- 10.1038/nclimate2826 is OK
- 10.1038/nclimate3186 is OK
- 10.1016/j.envsci.2017.04.020 is OK
- 10.7910/DVN/O3H22Z is OK
- 10.7910/DVN/RIBJXF is OK
- 10.6084/m9.figshare.5917399 is OK
- 10.6084/m9.figshare.5917402 is OK
- 10.6084/m9.figshare.5917408 is OK
- 10.6084/m9.figshare.7637669 is OK
- 10.1080/14693062.2018.1430018 is OK
- 10.5281/zenodo.2590636 is OK

MISSING DOIs

- https://doi.org/10.1007/978-3-531-92258-4_12 may be missing for title: The Greenhouse Development Rights Framework. The Right to Development in a Climate Constrained World, Second Edition
- https://doi.org/10.2139/ssrn.3279932 may be missing for title: The Greenhouse Development Rights and Climate Equity Reference Calculator Engine
- https://doi.org/10.1007/978-3-319-69772-7 may be missing for title: Norway’s Fair Share of Meeting the Paris Agreement
- https://doi.org/10.4324/9781315103358-12 may be missing for title: Climate Inequality in the Commonwealth: A Call for Urgent Action
- https://doi.org/10.4135/9781483351384.n48 may be missing for title: Special Report on the Impacts of Global Warming of 1.5°C Above Pre-Industrial Levels and Related Global Greenhouse Gas Emission Pathways, in the Context of Strengthening the Global Response to the Threat of Climate Change, Sustainable Development, and Efforts to Eradicate Poverty
- https://doi.org/10.1007/978-1-4302-0172-4_1 may be missing for title: SQLite (Version 3)
- https://doi.org/10.4135/9781473975101 may be missing for title: Paris Agreement
- https://doi.org/10.2139/ssrn.3286257 may be missing for title: Synthesis Report on the Aggregate Effect of the Intended Nationally Determined Contributions
- https://doi.org/10.1007/springerreference_29771 may be missing for title: The Emissions Gap Report 2015
- https://doi.org/10.1186/s12939-017-0700-1 may be missing for title: Fast, Fair Climate Action Crucial for Health and Equity

INVALID DOIs

- None

labarba commented 5 years ago

@whedon accept deposit=true

whedon commented 5 years ago

Doing it live! Attempting automated processing of paper acceptance...

whedon commented 5 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/557
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01273
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

labarba commented 5 years ago

Congratulations, @krueschan, your JOSS paper is published!

Big thanks to the editor: @jedbrown, and reviewer: @mtobis 🙏

whedon commented 5 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01273/status.svg)](https://doi.org/10.21105/joss.01273)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01273">
  <img src="http://joss.theoj.org/papers/10.21105/joss.01273/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01273/status.svg
   :target: https://doi.org/10.21105/joss.01273

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: http://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://www.flipcause.com/secure/cause_pdetails/Mjk3Nzk=

krueschan commented 5 years ago

Thanks very much, @jedbrown @mtobis @labarba and of course @whedon for this smooth review experience.

arfon commented 1 year ago

@editorialbot reaccept

editorialbot commented 1 year ago

Rebuilding paper!

editorialbot commented 1 year ago

:warning: Couldn't update published paper. An error happened. The generated XML metadata file is invalid.

Element issue: [facet 'maxLength'] The value has a length of '50'; this exceeds the allowed maximum length of '32'.

editorialbot commented 1 year ago

:warning: Couldn't update published paper. An error happened. The generated XML metadata file is invalid.

Element issue: [facet 'maxLength'] The value has a length of '50'; this exceeds the allowed maximum length of '32'.

arfon commented 1 year ago

@editorialbot reaccept

editorialbot commented 1 year ago

Rebuilding paper!

editorialbot commented 1 year ago

:warning: Couldn't update published paper. An error happened. The generated XML metadata file is invalid.

Element issue: [facet 'maxLength'] The value has a length of '50'; this exceeds the allowed maximum length of '32'.

mtobis commented 1 year ago

No idea what this is all about. Please leave me off the distribution, at least until you get it sorted.

mt

On Wed, Aug 30, 2023 at 12:34 PM The Open Journals editorial robot < @.***> wrote:

⚠️ Couldn't update published paper. An error happened https://github.com/openjournals/joss-papers/actions/runs/6027584235?check_suite_focus=true. The generated XML metadata file is invalid.

Element issue: [facet 'maxLength'] The value has a length of '50'; this exceeds the allowed maximum length of '32'.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1273#issuecomment-1699504700, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASXKOJEJYMEJWYP2OVGOPTXX5TSHANCNFSM4GZYMAKA . You are receiving this because you were mentioned.Message ID: @.***>

jedbrown commented 1 year ago

@mtobis Sorry about this -- we'll figure out a better workflow for the future. I can't remove you from the issue, but you can click unsubscribe in the right margin.

editorialbot commented 1 year ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/4527

openjournals / joss-reviews