openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
698 stars 36 forks source link

[PRE REVIEW]: VBLinLogit: Variational Bayesian linear and logistic regression #1314

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @jdrugo (Jan Drugowitsch) Repository: https://github.com/DrugowitschLab/VBLinLogit Version: v0.2 Editor: @usethedata Reviewers: @ManuelaS

Author instructions

Thanks for submitting your paper to JOSS @jdrugo. Currently, there isn't an JOSS editor assigned to your paper.

@jdrugo if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1314 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 13 0 13 0 0 244 0 --:--:-- --:--:-- --:--:-- 250 Error reading bibliography ./paper.bib (line 113, column 3): unexpected "a" expecting space or "," Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

kyleniemeyer commented 5 years ago

@jdrugo looks like there is an error in your bibliography preventing compilation of the paper.

kyleniemeyer commented 5 years ago

@eramirem and @arokem as the resident machine learning editors, could one of you handle this submission?

jdrugo commented 5 years ago

@kyleniemeyer I have fixed the paper.bib typo upstream. How do I get whedon to pick up that change?

kyleniemeyer commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jdrugo commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jdrugo commented 5 years ago

The article proof looks good now.

labarba commented 5 years ago

Hi @jdrugo — we're looking to assign a handling editor for your submission (I am the Associated Editor in Chief on rotation this week). Before we move forward, I do have some comments on your paper.

From our Review Criteria, the paper should contain:

I want to emphasize the need for explaining the software to a diverse audience: currently, I don't see this in the paper; the second paragraph is especially jargon-heavy. You also don't mention if this software has been used in any research projects.

Note also the section on "novelty":

Submissions that implement solutions already solved in other software packages are accepted into JOSS provided that they meet the criteria listed above and cite prior similar work.

Can you comment about existing related functionality in Matlab? For example, the Matlab documentation has a section on Bayesian regression models. How does your software fill a gap in this ecosystem?

labarba commented 5 years ago

@usethedata — Taking into account editor workloads at the moment, I'd like to assign this submission to you for handling. Can you take it on? You're a statistician!

usethedata commented 5 years ago

@whedon assign @usethedata as editor

whedon commented 5 years ago

OK, the editor is @usethedata

labarba commented 5 years ago

@whedon check references

whedon commented 5 years ago
Attempting to check references...
whedon commented 5 years ago

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1214/06-ba126 may be missing for title: Variational Algorithms for Approximate Bayesian Inference
- https://doi.org/10.1108/03684920710743466 may be missing for title: Pattern Recognition and Machine Learning
- https://doi.org/10.1002/sim.1856 may be missing for title: Bayesian Data Analysis
- https://doi.org/10.2307/1271145 may be missing for title: Markov Chain Monte Carlo in Practice
- https://doi.org/10.1007/978-0-387-21606-5_14 may be missing for title: The Elements of Statistical Learning
- https://doi.org/10.1002/9781118266502.scard may be missing for title: Machine Learning: A Probabilistic Perspective
- https://doi.org/10.1145/1273496.1273625 may be missing for title: A New View of Automatic Relevance Determination
- https://doi.org/10.7551/mitpress/7503.001.0001 may be missing for title: Advances in Neural Information Processing Systems 20, Proceedings of the Twenty-First Annual Conference on Neural Information Processing Systems, Vancouver, British Columbia, Canada, December 3-6, 2007
- https://doi.org/10.1111/j.2517-6161.1996.tb02080.x may be missing for title: Regression Shrinkage and Selection via the Lasso
- https://doi.org/10.1162/neco.1992.4.3.415 may be missing for title: Bayesian Interpolation
- https://doi.org/10.1007/978-1-4612-0745-0 may be missing for title: Bayesian Learning for Neural Networks
- https://doi.org/10.1109/icdm.2012.58 may be missing for title: Sparse Bayesian Learning and the Relevance Vector Machine
- https://doi.org/10.2172/1128035 may be missing for title: Variational Bayesian inference for linear and logistic regression

INVALID DOIs

- None
labarba commented 5 years ago

@jdrugo — Can you check your bibliography entries and add a DOI whenever one exists? Our helpful bot whedon has given some clues above for possible missing DOIs (it's not perfect, so some could be flukes).

jdrugo commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jdrugo commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jdrugo commented 5 years ago

@labarba -- Thank you for your comments. I have now updated the paper accordingly, and have added DOIs whenever available.

labarba commented 5 years ago

Did you also address my other comment, above? https://github.com/openjournals/joss-reviews/issues/1314#issuecomment-473580071

jdrugo commented 5 years ago

@labarba - yes, the updated version is an attempt to address these comments. I didn't go so far as to explain what linear and logistic regression are (I hope this knowledge can be assumed), but tried to simplify the summary.

usethedata commented 5 years ago

@jdrugo My apologies for my delays in getting back to this submission. My work life got a bit intense. The revised manuscript looks good from my perspective. Let me see about getting some reviewers assigned to this.

usethedata commented 5 years ago

@whedon assign @ManuelaS as reviewer

whedon commented 5 years ago

OK, the reviewer is @ManuelaS

usethedata commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1359. Feel free to close this issue now!

usethedata commented 5 years ago

closing pre-review issue.